Skip to content

Warn only when Fantom root creation changes global dimensions #59512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rubennorte wants to merge 1 commit into from
Closed

Warn only when Fantom root creation changes global dimensions #59512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions private/react-native-fantom/__docs__/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ describe('My feature', () => {
Creating a root sets global `Dimensions` for both `window` and `screen` from its
`viewportWidth`, `viewportHeight`, `devicePixelRatio`, and optional `fontScale`
(default `1`). `useWindowDimensions()` and `PixelRatio` report the new root's
values. If another root is still alive with different display metrics, Fantom
applies the new values and emits a warning. Call `root.destroy()` when a root is
no longer needed.
values. If another root is still alive and the new metrics differ from the
current global dimensions, Fantom applies the new values and emits a warning.
Call `root.destroy()` when a root is no longer needed.

For a full API reference, please see the [inline documentation](../src/index.js)
defined for the methods in the `@react-native/fantom` [module](../src/index.js).
Expand Down
7 changes: 5 additions & 2 deletions private/react-native-fantom/src/__tests__/FantomDimensions-itest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,15 @@ for (const [name, config] of conflictingConfigs) {
});
}

it('checks all active roots, including one that differs from the latest root', () => {
it('compares new metrics only with the current global dimensions', () => {
createRoot();
createRoot({viewportWidth: 640});
createRoot({viewportWidth: 640});
expect(warn).toHaveBeenCalledTimes(2);
expect(warn).toHaveBeenCalledTimes(1);
expect(Dimensions.get('window').width).toBe(640);
createRoot();
expect(warn).toHaveBeenCalledTimes(2);
expect(Dimensions.get('window').width).toBe(390);
});

it('does not warn for a destroyed root', () => {
Expand Down
25 changes: 12 additions & 13 deletions private/react-native-fantom/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,21 +84,20 @@ function pushDimensions(
surfaceId: RootTag,
displayMetrics: DisplayMetrics,
): void {
const previousDisplayMetrics = Dimensions.get('window');
activeRootDisplayMetrics.set(surfaceId, displayMetrics);
Dimensions.set({window: displayMetrics, screen: displayMetrics});
for (const metrics of activeRootDisplayMetrics.values()) {
if (
metrics.width !== displayMetrics.width ||
metrics.height !== displayMetrics.height ||
metrics.scale !== displayMetrics.scale ||
metrics.fontScale !== displayMetrics.fontScale
) {
console.warn(
'Fantom.createRoot() updated global Dimensions while another active root has different display metrics. Dimensions and PixelRatio now reflect the new root.',
{existingRoot: metrics, newRoot: displayMetrics},
);
break;
}
if (
activeRootDisplayMetrics.size > 1 &&
(previousDisplayMetrics.width !== displayMetrics.width ||
previousDisplayMetrics.height !== displayMetrics.height ||
previousDisplayMetrics.scale !== displayMetrics.scale ||
previousDisplayMetrics.fontScale !== displayMetrics.fontScale)
) {
console.warn(
'Fantom.createRoot() updated global Dimensions while another active root has different display metrics. Dimensions and PixelRatio now reflect the new root.',
{existingRoot: previousDisplayMetrics, newRoot: displayMetrics},
);
}
}

Expand Down
Loading