Skip to content

Make the default configuration constexpr - #59515

Closed
javache wants to merge 2 commits into
react:mainfrom
javache:export-D127577561
Closed

javache wants to merge 2 commits into
react:mainfrom
javache:export-D127577561

Conversation

@javache

@javache javache commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Summary:
X-link: react/yoga#2050

Constant-initialize the default configuration and resolve its default logger only when logging. Expose the configuration to constant evaluation on non-Windows platforms; retain the out-of-line Windows getter so DLL consumers continue sharing the library-owned singleton.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D127577561

Summary:
Pull Request resolved: react#59489

Enforce constant initialization for eligible native globals, static defaults, synchronization primitives, and thread-local state without changing their mutability or lifetime.

Changelog: [Internal]

Reviewed By: christophpurrer, cipolleschi

Differential Revision: D127576609
Summary:
X-link: react/yoga#2050

Constant-initialize the default configuration and resolve its default logger only when logging. Expose the configuration to constant evaluation on non-Windows platforms; retain the out-of-line Windows getter so DLL consumers continue sharing the library-owned singleton.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D127577561
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 26, 2026
@meta-codesync

meta-codesync Bot commented Oct 26, 2026

Copy link
Copy Markdown

@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127577561.

meta-codesync Bot pushed a commit to facebook/litho that referenced this pull request Oct 26, 2026
Summary:
X-link: react/react-native#59515

X-link: react/yoga#2050

Constant-initialize the default configuration and resolve its default logger only when logging. Expose the configuration to constant evaluation on non-Windows platforms; retain the out-of-line Windows getter so DLL consumers continue sharing the library-owned singleton.

Changelog: [Internal]

Reviewed By: christophpurrer

Differential Revision: D127577561

fbshipit-source-id: 017d21f8b797e412649fde0b5829df17f464436c
@meta-codesync meta-codesync Bot closed this in 1d9ed87 Oct 26, 2026
@meta-codesync meta-codesync Bot added the Merged This PR has been merged. label Oct 26, 2026
@meta-codesync

meta-codesync Bot commented Oct 26, 2026

Copy link
Copy Markdown

This pull request has been merged in 1d9ed87.

@javache
javache deleted the export-D127577561 branch October 26, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant