Skip to content

fix(build)!: honor consumer implicit usings - #4539

Merged
glennawatson merged 1 commit into
mainfrom
fix/implicit-usings-consumers
Oct 12, 2026
Merged

glennawatson merged 1 commit into
mainfrom
fix/implicit-usings-consumers

Conversation

@glennawatson

Copy link
Copy Markdown
Contributor

Summary

Respect the consuming project's ImplicitUsings setting in the package imports.

  • Gate the lean, Reactive and WPF transitive namespace imports on true or enable.
  • No test file is added. MSBuild evaluation of each package props file and a consuming project checks the package behavior directly.

Why

Projects with <ImplicitUsings>false</ImplicitUsings> receive ReactiveUI global usings from the packages. Closes #4535.

Breaking changes

Projects that disable implicit usings must add explicit using directives for ReactiveUI binding namespaces they use.

How this was verified

MSBuild evaluation found zero package usings with false and the expected package usings with true and enable for all four props files. Both core flavors built on net10.0 and net11.0 with zero warnings. The net10.0 ReactiveUI and ReactiveUI.Reactive test projects passed (880 and 882 tests).

Notes for the reviewer

The WPF props files were checked through MSBuild item evaluation; WPF assemblies were not built on Linux.

Checklist

  • I have read the Contribute guide
  • The PR title follows Conventional Commits
  • Tests cover this change, or the summary says why they do not
  • New or changed public API has XML documentation

- Gate transitive namespace imports on the consuming project setting.
- Match the SDK values true and enable across lean, Reactive and WPF packages.
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.75%. Comparing base (8831268) to head (92c74ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4539   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files         175      175           
  Lines        6182     6182           
  Branches      736      736           
=======================================
  Hits         5796     5796           
  Misses        386      386           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@glennawatson
glennawatson merged commit dae5e93 into main Oct 12, 2026
19 checks passed
@glennawatson
glennawatson deleted the fix/implicit-usings-consumers branch October 12, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Global usings included unconditionally.

1 participant