Repository navigation
fix(build)!: honor consumer implicit usings - #4539
Merged
Merged
Conversation
- Gate transitive namespace imports on the consuming project setting. - Match the SDK values true and enable across lean, Reactive and WPF packages.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4539 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 175 175
Lines 6182 6182
Branches 736 736
=======================================
Hits 5796 5796
Misses 386 386 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Respect the consuming project's
ImplicitUsingssetting in the package imports.trueorenable.Why
Projects with
<ImplicitUsings>false</ImplicitUsings>receive ReactiveUI global usings from the packages. Closes #4535.Breaking changes
Projects that disable implicit usings must add explicit
usingdirectives for ReactiveUI binding namespaces they use.How this was verified
MSBuild evaluation found zero package usings with
falseand the expected package usings withtrueandenablefor all four props files. Both core flavors built onnet10.0andnet11.0with zero warnings. Thenet10.0ReactiveUI and ReactiveUI.Reactive test projects passed (880 and 882 tests).Notes for the reviewer
The WPF props files were checked through MSBuild item evaluation; WPF assemblies were not built on Linux.
Checklist