Skip to content

Commit fe64bc3

Browse files
Merge branch 'main' into deltasignal-column-help-3
2 parents a7040cb + f3c0455 commit fe64bc3

2 files changed

Lines changed: 19 additions & 0 deletions

File tree

‎projects/pathway-browser/src/app/model/graph/event/event.model.ts‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,14 @@ import { GO_BiologicalProcess } from '../go-term/go-biological-process.model';
1515
* As /data/query/enhanced sends it, which leaves out what an event has none of:
1616
* of 15 sampled pathways one had authors, reviewers or a review status, and
1717
* three of 15 reactions (#344).
18+
*
19+
* Asked without `includeRef=true` (either version), a list such as
20+
* `literatureReference` can hold bare dbIds where the object was written
21+
* earlier in the answer, often in the parent pathway (`eventOf`) or a preceding
22+
* or following event; the types here do not say so. Dropping them loses
23+
* references, as production's browser does (#760). Ask with `includeRef=true`
24+
* and read through JSOGDeserializer, which resolves its back-references
25+
* (`@ref`) to the objects they name, as the details pages do.
1826
*/
1927
export interface Event extends DatabaseObject, InDepth, HasFigure {
2028
stId: string;

‎tools/content-node/data-query-endpoints.ts‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -391,6 +391,17 @@ export const dataQueryEndpoints: Endpoint[] = [
391391
* serialiser in the request's view. The entity popup, the website's
392392
* content pages and the IDG panel read it.
393393
*
394+
* Kept byte for byte as Java answers it, so it keeps a trap. Without
395+
* `includeRef=true`, this answer and /enhanced/v2 alike write an object in
396+
* full only once and later as its bare dbId; and an event's neighbours (its
397+
* preceding and following events, and since graph-core bb5e0ca0, Aug 2025,
398+
* its parent pathways, `eventOf`) come before its `literatureReference` and
399+
* the lists after it. A reference a neighbour also cites is therefore a bare
400+
* number in the event's list, and a reader that keeps only objects loses it,
401+
* which is #760 on production. Ask with `includeRef=true`, which marks each
402+
* object with `@id` and points back with `{"@ref": …}`, and read through the
403+
* site's JSOGDeserializer, as the details pages do (with v2).
404+
*
394405
* Its relationships go both ways unless QueryObjectController's
395406
* needsIncomingRelationship says not (needsIncoming). The id is read as
396407
* getIdentifier reads it (inDepthId).

0 commit comments

Comments
 (0)