Repository navigation
Content service image: its packages at the lockfile's versions - #701
Merged
Merged
Conversation
From #699's review: neo4j-driver's root range (^6.2.0) let the image take the newest 6.x at build time, untested here. Each package must still be a dependency of the root package.json, and is installed at the version the root lockfile resolved for it; one missing from either fails the build, naming it. Today that is express 5.3.0 and neo4j-driver 6.2.0, as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #699, from its review. neo4j-driver's root range (
^6.2.0) let the image take the newest 6.x at build time, untested here.Each package the service imports (express, neo4j-driver) must still be a dependency of the root
package.json. It is now installed at the exact version the rootpackage-lock.jsonresolved for it. If either is missing, the build fails, naming it. I checked with the driver taken out of a copy of the lockfile:Error: neo4j-driver is not in the root lockfile, exit 1.Built and inspected: the image's package.json pins
express 5.3.0andneo4j-driver 6.2.0, and those are what is installed, the same as beta runs now. Neither root copy is left in the image.Still floating: the two packages' own dependencies resolve at build time within their ranges, as before and as in the render image.
Preflight passes.
🤖 Generated with Claude Code