Repository navigation
Spec 016 T013: the search answers in the contract - #702
Closed
adamjohnwright wants to merge 2 commits into
Closed
adamjohnwright wants to merge 2 commits into
adamjohnwright wants to merge 2 commits into
Conversation
ResultGroup, GroupedResult, DiagramResult, TargetResult and IconResult, each taking its entry type as an argument: the service writes them with the entries it builds, the site and the pathway browser read them with the view. A group's entries and type name are optional, as the service leaves them out at times; the search page settles both once on arrival, and the pathway browser shows only named type facets, as the site does. Solr's grouping without matches is Java's 500, as one without ngroups was. The search routes' known problems are 0 (from 11,452 before spec 016); the whole is 12,164. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ads it SolrJ does not unbox a grouping's matches: extractGroupedInfo skips a grouping that has none (its bytecode), and the converter reads the first grouping it kept. So the service reads the first grouping with matches, and none is no result -- the same 500 for the one grouping this index asks for, and the right one where several are answered. The comment, the spec and tasks.md said SolrJ unboxes it; they say what it does now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by 703: the same commits, rebased onto main after #701. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #700, with its review's finding fixed (second commit). That review compared node with Java's own service live and found no answer changed. It did find my reason for the
matchesfailure wrong: SolrJ does not unbox a grouping's matches.QueryResponse.extractGroupedInfoskips a grouping without them (I read it in the bytecode,ifnonnull … goto), and the converter reads the first grouping kept. So the service now reads the first grouping that has its matches, and none is no result. That is the same 500 for the one grouping this index asks for, and the right reading where several are answered. A spec of two groupings, the first without matches, fails on #700's reading and passes now. Redeployed on beta: 68 search answers identical, no errors.The search family's answers in the contract (spec 016 T013). With #691 and #697 this brings every search route's known problems to zero, from 11,452 before spec 016.
Contract types:
ResultGroup<Entry>,GroupedResult<Entry>,DiagramResult<Entry>,TargetResultandIconResult. Each takes its entry type as a named argument: the service writes them with itsWrittenEntry, and the site and the pathway browser read them with the view.What is written, typed as written:
entriesis optional: an ungrouped page past the end has none.typeName: a group Solr names with nothing has none.Writers:
searchResult,groupedEntriesand the diagram search'sentriesResultreturn the contract's types.matchesis skipped, as SolrJ skips it (see above); one withoutngroupsstays Java's 500, asGroupedResultunboxes it. Specs cover both.Readers:
SearchResultandIconResult, and the pathway browser'sSearch.ResultandSearch.Icon.Result, are the contract's.ShownGroup), and reads them as before.iconName, never highlighted (from Spec 016, from #691's review: a highlighted identifier shown as text #697's review).Checks:
🤖 Generated with Claude Code