Repository navigation
Spec 015 T069, from #755's review: check.sh's silent stop, old work, a fair cap - #756
Merged
Merged
Conversation
…a fair cap
check.sh's event selection used `grep && echo` in a loop: under pipefail a
last candidate not in its file ended the script silently; it is an if
now, and it matches the event's own database-id xref (its comment ends
with the id), not any numeric id. The service clears work left in the
layout before exports had a folder each (cache/tmp/{uuid}), with a test.
The shared cap is fair, so a waiting request of one export is not
overtaken by later ones of the other. Node's comment says the queued
worst case passes the headers' time and gets the 503, as T069 measured.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 015 (specs/015-graph-exports), T069: a follow-up to #755 (merged), from its review.
check.sh(medium):grep … && echoinside a loop. Underpipefail, a last candidate not in its species file ended the script silently. It passed only because the last candidate happens to be in its file today. Reproduced in a minimal case: the old form exits 1 with no output, the new form reaches the end. It is anifnow.&ID={dbId}, rather than any numericbp:id, such as a PubMed id.cache/tmp/{uuid}). Tested byworkLeftInTheLayoutBeforeExportsHadFoldersIsRemoved. Beta's cache holds none today.new Semaphore(2, true), so a waiting request of one export is not overtaken by later ones of the other.Checked here:
check.shpassed over both fixtures.Not seen failing: I did not see the new Java test fail locally, which would mean a second image build with the change reverted. Its assertion is direct: the leftover folder is gone after construction.
🤖 Generated with Claude Code