Repository navigation
DeltaSignal on beta, from #757's review: docs - #759
Merged
Merged
Conversation
…gle test checks it The nginx README and the e2e toggle test's header no longer say DeltaSignal cannot work on beta; the README says where its service runs and that beta's checks cover it. The toggle test now checks the button on beta as well as under the dev server. The search-answer flag's comment, also stale, names beta too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cording Renaming the e2e "on" case left it without the recorded backend its title keys, so CI failed; it keeps its name, and which profiles have the flag stays pinned by the unit test. The README's wording on which deployments may turn the flag on, and on checking the service, is plainer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up #757 (DeltaSignal's Perturb button on beta) with the low findings from its review. It replaces #758.
Changes
deploy/nginx/README.mdno longer says DeltaSignal cannot work on beta. It says:/api/is DeltaSignal's route;deltaSignalon;/api/pathwaysanswers a list, the service is up.e2e/deltasignal-toggle.spec.ts: its header no longer says/apibelongs only to the dev server.environments.ts: the search-answer flag's comment now names beta too.Changed from #758: #758 also added a beta case to the end-to-end toggle test, which renamed the "on" case. Each test's recorded backend is keyed by its title, so both cases ran without a recording and CI failed, as #758's review predicted. The "on" case keeps its name here. Which profiles have the flag (development and beta) stays pinned by the unit test in
environments.spec.ts, which #757 changed and which fails if beta loses the flag.Noted from the review, not changed:
/api/solvehas no rate limit of its own.Spec: none.
🤖 Generated with Claude Code