Repository navigation
Note where the old enhanced query drops references (#760) - #761
Closed
adamjohnwright wants to merge 1 commit into
Closed
adamjohnwright wants to merge 1 commit into
adamjohnwright wants to merge 1 commit into
Conversation
/data/query/enhanced keeps Java's answer byte for byte, including a bare dbId for an object written earlier; since graph-core bb5e0ca0 an event's parent pathways come first, so references its parent also cites are bare numbers in its own list. Production's browser loses them (#760). The endpoint and the event model now say to read an event's lists from /enhanced/v2, as the details pages do, so the new site does not copy the fault. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by the next PR, which corrects what this one said about v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds comments only, so the new site doesn't copy the fault behind #760.
The fault:
/ContentService/data/query/enhanced/{id}is kept byte for byte as Java answers it.eventOf) come before its own lists.literatureReference.The note goes on the node endpoint's definition (
tools/content-node/data-query-endpoints.ts) and on the site'sEventmodel. It says to read an event's lists from/enhanced/v2, which writes every object in full, as the details pages already do.No behaviour changes. The endpoint stays byte-identical to Java, as the port requires. The other places that read the old form (the entity popup, the IDG panel's summation, the schema browser's instance view) read no references. The instance view also turns a bare dbId into a link.
Refs #760.
🤖 Generated with Claude Code