Repository navigation
Specialization bridges (deltasignal specs/067), default add - #117
Merged
Merged
Conversation
…DGE=off|add|replace, default off) Join a copy of a specific complex to the copy of the generic complex it instantiates (same member leaves), where one is one member combination of the other and the curators order the two reactions by precedingEvent. Traced in Signaling by PDGF: autophosphorylation makes specific p-PDGFR complexes, every downstream step consumes the generic one, and nothing joined them. 'replace' also drops the boundary assembly into a bridged copy. export_nodes split into node_rows so the pass can read node identity. Reproduces the Neo4j census exactly: 61 pairs, 203 copy edges, 24 pathways. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ted: curator held-out +59, p 8.7e-7, experimental 0; replace failed the gate) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
adamjohnwright
marked this pull request as ready for review
October 17, 2026 10:43
…ialization_step), stubbed in the pipeline fixtures like the exports; with the default on it read Neo4j in the no-database tests Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the rule pre-registered in reactome/deltasignal#131 (specs/067), and makes
addthe default after adoption (Adam, 2026-10-17).Measured (deltasignal specs/067 research.md), against canonical
results/0709a1e:addreplaceCurator held-out in release 89.50% → 89.81%.
Change
src/specialization.py: the specialization relation (component one-to-one match, set membership, stoichiometry), the precedingEvent link test, copy matching on identical member leaves, and theadd/replaceedge application.export_nodessplit intonode_rows+ writer (output unchanged).add;offrestores the previous networks.tests/test_specialization.py(17). Full suite: 1222 passed; the one failure (test_main_edges_proportional_to_best_matches, MHC class I) reads a stale localoutput/directory from July and fails on main as well (checked).A canonical rebuild follows the merge.
🤖 Generated with Claude Code