Repository navigation
Summation regulations as a curation supplement (LNG_SUMMATION_REGULATIONS, deltasignal specs/102) - #127
Merged
Conversation
…ault off): regulations stated in Reactome summations, as structural rules Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er enumeration (as a curated participant it took RBL1/RBL2 phosphorylation past the cap and broke their recycle pools) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three reactions in Mitotic G1 make products that no Release 97 reaction uses. Each reaction's summation says what its product does.
src/summation_regulations.pywrites each of these as a structural rule. A rule applies only within a pathway that holds its source reaction:The regulators are added after variant enumeration, to every copy, as one pool of their variants (
<stId>::pool). This means they never multiply copies or push a reaction past the cap. A first build that wired them as curated participants broke the p130/p107 recycle pools; it was never benchmarked.Measured (deltasignal specs/102, pre-registered, against canonical defaults):
These edges add to Release 97 rather than reproduce it.
LNG_SUMMATION_REGULATIONS=0builds the release alone.Changes:
LNG_SUMMATION_REGULATIONS, default on.PIPELINE_SETTINGS.mdrow.tests/test_summation_regulations.py, including a live-database test of the registered targets.Checks: suite passes except the known stale
test_main_edges_proportional_to_best_matches[...983169]. mypy is clean.🤖 Generated with Claude Code