Skip to content

Commit 63cde9c

Browse files
authored
Merge pull request #276 from clue-labs/php8.5
Improve PHP 8.5+ support by avoiding deprecated `null` array offset
2 parents 119a945 + 0565b8d commit 63cde9c

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ jobs:
1111
strategy:
1212
matrix:
1313
php:
14+
- 8.5
1415
- 8.4
1516
- 8.3
1617
- 8.2
@@ -21,7 +22,7 @@ jobs:
2122
- 7.2
2223
- 7.1
2324
steps:
24-
- uses: actions/checkout@v5
25+
- uses: actions/checkout@v7
2526
- uses: shivammathur/setup-php@v2
2627
with:
2728
php-version: ${{ matrix.php }}
@@ -39,6 +40,7 @@ jobs:
3940
strategy:
4041
matrix:
4142
php:
43+
- 8.5
4244
- 8.4
4345
- 8.3
4446
- 8.2
@@ -48,7 +50,7 @@ jobs:
4850
- 7.3
4951
- 7.2
5052
steps:
51-
- uses: actions/checkout@v5
53+
- uses: actions/checkout@v7
5254
- uses: shivammathur/setup-php@v2
5355
with:
5456
php-version: ${{ matrix.php }}

‎src/Internal/CancellationQueue.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function enqueue($cancellable): void
4141

4242
private function drain(): void
4343
{
44-
for ($i = \key($this->queue); isset($this->queue[$i]); $i++) {
44+
for ($i = \key($this->queue) ?? 0; isset($this->queue[$i]); $i++) {
4545
$cancellable = $this->queue[$i];
4646
assert(\method_exists($cancellable, 'cancel'));
4747

0 commit comments

Comments
 (0)