Repository navigation
Improve PHP 8.5+ support by avoiding deprecated null array offset - #276
Merged
Merged
Conversation
WyriHaximus
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves PHP 8.5+ support by avoiding a deprecated
nullarray offset when cancelling and updates the test environment to run the test suite on PHP 8.5.This only affects cancelling a pending
race(),all()orany()without any cancellable inputs, which would report a deprecation notice on PHP 8.5 and otherwise work as expected. Promises from this package are always cancellable and plain values settle immediately. In practice, this only applies to third-party thenables without acancel()method or torace([]), which is rarely useful, but returns a forever pending promise for consistency with other implementations as discussed in #83 and #207.This is not backported to older versions, as Promise v2 does not support PHP 8.4+ anyway as discussed in #269, and v1 is not affected.
Builds on top of #275, #271, #264 and clue/framework-x#297
Refs #83, #207 and #269