Repository navigation
Expand file tree
/
Copy pathExpressionCreateMockToCreateStubRector.php
More file actions
132 lines (108 loc) · 3.48 KB
/
Copy pathExpressionCreateMockToCreateStubRector.php
File metadata and controls
132 lines (108 loc) · 3.48 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
<?php
declare(strict_types=1);
namespace Rector\PHPUnit\PHPUnit120\Rector\ClassMethod;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Identifier;
use PhpParser\Node\Stmt\ClassMethod;
use PhpParser\Node\Stmt\Expression;
use Rector\PHPUnit\CodeQuality\NodeAnalyser\AssignedMocksCollector;
use Rector\PHPUnit\CodeQuality\NodeAnalyser\MockObjectExprDetector;
use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\PHPUnit\Tests\PHPUnit120\Rector\ClassMethod\ExpressionCreateMockToCreateStubRector\ExpressionCreateMockToCreateStubRectorTest
*/
final class ExpressionCreateMockToCreateStubRector extends AbstractRector
{
public function __construct(
private readonly AssignedMocksCollector $assignedMocksCollector,
private readonly TestsNodeAnalyzer $testsNodeAnalyzer,
private readonly MockObjectExprDetector $mockObjectExprDetector,
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Replace createMock() assigned to variable that is only used as arg with no expectations, to createStub()',
[
new CodeSample(
<<<'CODE_SAMPLE'
use PHPUnit\Framework\TestCase;
final class SomeTest extends TestCase
{
public function test(): void
{
$mock = $this->createMock(SomeClass::class);
$someObject = new SomeClass($mock);
$this->assertSame($mock, $someObject->getDependency());
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
use PHPUnit\Framework\TestCase;
final class SomeTest extends TestCase
{
public function test(): void
{
$mock = $this->createStub(SomeClass::class);
$someObject = new SomeClass($mock);
$this->assertSame($mock, $someObject->getDependency());
}
}
CODE_SAMPLE
),
]
);
}
public function getNodeTypes(): array
{
return [ClassMethod::class];
}
/**
* @param ClassMethod $node
*/
public function refactor(Node $node): ?ClassMethod
{
if (! $this->testsNodeAnalyzer->isTestClassMethod($node)) {
return null;
}
if ($node->stmts === null || count($node->stmts) < 2) {
return null;
}
$hasChanged = false;
foreach ($node->stmts as $stmt) {
if (! $stmt instanceof Expression) {
continue;
}
if (! $stmt->expr instanceof Assign) {
continue;
}
$typeArg = $this->assignedMocksCollector->matchCreateMockArgAssignedToVariable($stmt->expr);
if (! $typeArg instanceof Arg) {
continue;
}
$assign = $stmt->expr;
if (! $assign->var instanceof Variable) {
continue;
}
if ($this->mockObjectExprDetector->isUsedForMocking($assign->var, $node)) {
continue;
}
/** @var MethodCall $methodCall */
$methodCall = $assign->expr;
$methodCall->name = new Identifier('createStub');
$hasChanged = true;
}
if ($hasChanged) {
return $node;
}
return null;
}
}