Repository navigation
Expand file tree
/
Copy pathGetMockBuilderGetMockToCreateMockRector.php
More file actions
138 lines (117 loc) · 3.73 KB
/
Copy pathGetMockBuilderGetMockToCreateMockRector.php
File metadata and controls
138 lines (117 loc) · 3.73 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
<?php
declare(strict_types=1);
namespace Rector\PHPUnit\PHPUnit60\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\Variable;
use PHPStan\Type\ObjectType;
use Rector\Rector\AbstractRector;
use Rector\VersionBonding\Contract\ComposerPackageConstraintInterface;
use Rector\VersionBonding\ValueObject\ComposerPackageConstraint;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://github.com/lmc-eu/steward/pull/187/files#diff-c7e8c65e59b8b4ff8b54325814d4ba55L80
*
* @see \Rector\PHPUnit\Tests\PHPUnit60\Rector\MethodCall\GetMockBuilderGetMockToCreateMockRector\GetMockBuilderGetMockToCreateMockRectorTest
*/
final class GetMockBuilderGetMockToCreateMockRector extends AbstractRector implements ComposerPackageConstraintInterface
{
/**
* createMock() was added in PHPUnit 5.4
*/
public function provideComposerPackageConstraint(): ComposerPackageConstraint
{
return new ComposerPackageConstraint('phpunit/phpunit', '>=5.4');
}
/**
* @var string[]
*/
private const array USELESS_METHOD_NAMES = [
'disableOriginalConstructor',
'disableOriginalClone',
'disableArgumentCloning',
'disallowMockingUnknownTypes',
];
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Remove getMockBuilder() to createMock()', [
new CodeSample(
<<<'CODE_SAMPLE'
use PHPUnit\Framework\TestCase;
final class SomeTest extends TestCase
{
public function test()
{
$applicationMock = $this->getMockBuilder('SomeClass')
->disableOriginalConstructor()
->getMock();
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
use PHPUnit\Framework\TestCase;
final class SomeTest extends TestCase
{
public function test()
{
$applicationMock = $this->createMock('SomeClass');
}
}
CODE_SAMPLE
),
]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [MethodCall::class];
}
/**
* @param MethodCall $node
*/
public function refactor(Node $node): ?Node
{
if (! $this->isName($node->name, 'getMock')) {
return null;
}
if (! $node->var instanceof MethodCall) {
return null;
}
// traverse up over useless methods until we reach the top one
$currentMethodCall = $node->var;
while ($currentMethodCall instanceof MethodCall && $this->isNames(
$currentMethodCall->name,
self::USELESS_METHOD_NAMES
)) {
$currentMethodCall = $currentMethodCall->var;
}
if (! $currentMethodCall instanceof MethodCall) {
return null;
}
// can be only local call, as createMock() is protected method
if (! $this->isLocalScopeCaller($currentMethodCall)) {
return null;
}
// must be be test case class
if (! $this->isObjectType($currentMethodCall->var, new ObjectType('PHPUnit\Framework\TestCase'))) {
return null;
}
if (! $this->isName($currentMethodCall->name, 'getMockBuilder')) {
return null;
}
$args = $currentMethodCall->args;
$thisVariable = $currentMethodCall->var;
return new MethodCall($thisVariable, 'createMock', $args);
}
private function isLocalScopeCaller(MethodCall $currentMethodCall): bool
{
if (! $currentMethodCall->var instanceof Variable) {
return false;
}
return $currentMethodCall->var->name === 'this';
}
}