[CodeQuality] Use static Assert:: call for assert() inside anonymous class in AssertFuncCallToPHPUnitAssertRector

Author: TomasVotruba

rules-tests/CodeQuality/Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector/Fixture/assert_inside_anonymous_class.php.inc

@@ -0,0 +1,41 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertInsideAnonymousClass extends TestCase
+{
+    public function some($response)
+    {
+        return new class($response) {
+            public function __construct($response)
+            {
+                assert((bool) $response);
+            }
+        };
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\FuncCall\AssertFuncCallToPHPUnitAssertRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class AssertInsideAnonymousClass extends TestCase
+{
+    public function some($response)
+    {
+        return new class($response) {
+            public function __construct($response)
+            {
+                \PHPUnit\Framework\Assert::assertTrue((bool) $response);
+            }
+        };
+    }
+}
+
+?>

rules/CodeQuality/NodeAnalyser/DoctrineEntityDocumentAnalyser.php

@@ -32,6 +32,12 @@ public function isEntityClass(string $className): bool
             return false;
         }
 
-        return array_any(self::ENTITY_DOCBLOCK_MARKERS, fn(string $entityDocBlockMarkers): bool => str_contains($resolvedPhpDocBlock->getPhpDocString(), $entityDocBlockMarkers));
+        return array_any(
+            self::ENTITY_DOCBLOCK_MARKERS,
+            fn (string $entityDocBlockMarkers): bool => str_contains(
+                $resolvedPhpDocBlock->getPhpDocString(),
+                $entityDocBlockMarkers
+            )
+        );
     }
 }

rules/CodeQuality/Rector/ClassMethod/ReplaceTestAnnotationWithPrefixedFunctionRector.php

@@ -4,7 +4,6 @@
 
 namespace Rector\PHPUnit\CodeQuality\Rector\ClassMethod;
 
-use function in_array;
 use PhpParser\Comment\Doc;
 use PhpParser\Node;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -16,6 +15,7 @@
 use Rector\Util\NewLineSplitter;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use function in_array;
 
 /**
  * @see \Rector\PHPUnit\Tests\CodeQuality\Rector\ClassMethod\ReplaceTestAnnotationWithPrefixedFunctionRector\ReplaceTestAnnotationWithPrefixedFunctionRectorTest
@@ -86,7 +86,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $hasAnnotation = array_any(NewLineSplitter::split($docComment->getText()), fn(string $row): bool => in_array(trim($row), ['*@test', '* @test'], true));
+        $hasAnnotation = array_any(
+            NewLineSplitter::split($docComment->getText()),
+            fn (string $row): bool => in_array(trim($row), ['*@test', '* @test'], true)
+        );
 
         if (! $hasAnnotation) {
             return null;

rules/CodeQuality/Rector/Class_/PreferTestsWithCamelCaseRector.php

@@ -4,8 +4,8 @@
 
 namespace Rector\PHPUnit\CodeQuality\Rector\Class_;
 
-use PhpParser\Node\Identifier;
 use PhpParser\Node;
+use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\Class_;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;

rules/CodeQuality/Rector/Class_/PreferTestsWithSnakeCaseRector.php

@@ -4,8 +4,8 @@
 
 namespace Rector\PHPUnit\CodeQuality\Rector\Class_;
 
-use PhpParser\Node\Identifier;
 use PhpParser\Node;
+use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\Class_;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;

rules/CodeQuality/Rector/Expression/AssertArrayCastedObjectToAssertSameRector.php

@@ -161,6 +161,6 @@ public function refactor(Node $node): ?array
      */
     private function hasAllKeysString(array $assertedArrayValues): bool
     {
-        return array_all(array_keys($assertedArrayValues), fn(int|string $key): bool => is_string($key));
+        return array_all(array_keys($assertedArrayValues), fn (int|string $key): bool => is_string($key));
     }
 }

rules/CodeQuality/Rector/FuncCall/AssertFuncCallToPHPUnitAssertRector.php

@@ -110,6 +110,12 @@ public function refactor(Node $node): ?Class_
                     return null;
                 }
 
+                // assert() inside an anonymous class has no $this of the test case
+                if ($node instanceof Class_ && $node->isAnonymous()) {
+                    $useStaticAssert = true;
+                    return null;
+                }
+
                 if (! $node instanceof FuncCall) {
                     return null;
                 }

rules/PHPUnit120/Rector/Class_/AllowMockObjectsWhereParentClassRector.php

@@ -119,6 +119,6 @@ private function hasRelateParentClass(Class_ $class): bool
             return false;
         }
 
-        return array_any(self::PARENT_CLASSES, fn(string $parentClass): bool => $classReflection->is($parentClass));
+        return array_any(self::PARENT_CLASSES, fn (string $parentClass): bool => $classReflection->is($parentClass));
     }
 }

rules/PHPUnit120/Rector/Class_/AllowMockObjectsWithoutExpectationsAttributeRector.php

@@ -270,7 +270,10 @@ private function shouldAddAttribute(array $missedTestMethodsByMockPropertyName):
      */
     private function isAtLeastOneMockPropertyMockedOnce(array $usingTestMethodsByMockPropertyName): bool
     {
-        return array_any($usingTestMethodsByMockPropertyName, fn(array $usingTestMethods): bool => $usingTestMethods !== []);
+        return array_any(
+            $usingTestMethodsByMockPropertyName,
+            fn (array $usingTestMethods): bool => $usingTestMethods !== []
+        );
     }
 
     private function isMissingExpectsOnMockObjectMethodCallInSetUp(Class_ $class): bool

src/NodeAnalyzer/AssertCallAnalyzer.php

@@ -97,7 +97,10 @@ public function isAssertMethodCall(MethodCall|StaticCall $call): bool
             return false;
         }
 
-        return array_any(self::ASSERT_METHOD_NAME_PREFIXES, fn(string $assertMethodNamePrefix): bool => str_starts_with($callName, $assertMethodNamePrefix));
+        return array_any(
+            self::ASSERT_METHOD_NAME_PREFIXES,
+            fn (string $assertMethodNamePrefix): bool => str_starts_with($callName, $assertMethodNamePrefix)
+        );
     }
 
     private function hasDirectAssertOrMockCall(ClassMethod $classMethod): bool