[CodeQuality] Add PHPUNIT_NARROW_ASSERTS set focused on narrowing broad asserts to specific methods (#716)

* [CodeQuality] Add PHPUNIT_NARROW_ASSERTS set focused on narrowing broad asserts to specific methods

* Exclude UseSpecificWillMethodRector, not an assert narrowing

* Exclude SimplifyForeachInstanceOfRector too

* Drop AssertFuncCallToPHPUnitAssertRector and UseSpecificWithMethodRector, not narrowing asserts

Author: TomasVotruba

config/sets/phpunit-narrow-asserts.php

@@ -0,0 +1,41 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\PHPUnit\CodeQuality\Rector\Expression\AssertArrayCastedObjectToAssertSameRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertCompareOnCountableWithMethodToAssertCountRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertComparisonToSpecificMethodRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertEmptyNullableObjectToAssertInstanceofRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertEqualsToSameRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertFalseStrposToContainsRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertInstanceOfComparisonRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertIssetToSpecificMethodRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertNotOperatorRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertSameBoolNullToSpecificMethodRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertSameTrueFalseToAssertTrueFalseRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\AssertTrueFalseToSpecificMethodRector;
+use Rector\PHPUnit\CodeQuality\Rector\MethodCall\MatchAssertSameExpectedTypeRector;
+
+/**
+ * Narrow broad asserts to their specific, more descriptive method calls,
+ * e.g. assertTrue(isset($a['b'])) => assertArrayHasKey('b', $a).
+ */
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rules([
+        AssertCompareOnCountableWithMethodToAssertCountRector::class,
+        AssertComparisonToSpecificMethodRector::class,
+        AssertNotOperatorRector::class,
+        AssertTrueFalseToSpecificMethodRector::class,
+        AssertSameBoolNullToSpecificMethodRector::class,
+        AssertFalseStrposToContainsRector::class,
+        AssertIssetToSpecificMethodRector::class,
+        AssertInstanceOfComparisonRector::class,
+        AssertEmptyNullableObjectToAssertInstanceofRector::class,
+
+        AssertEqualsToSameRector::class,
+        AssertSameTrueFalseToAssertTrueFalseRector::class,
+        MatchAssertSameExpectedTypeRector::class,
+        AssertArrayCastedObjectToAssertSameRector::class,
+    ]);
+};

src/Set/PHPUnitSetList.php

@@ -31,5 +31,7 @@ final class PHPUnitSetList
 
     public const string PHPUNIT_CODE_QUALITY = __DIR__ . '/../../config/sets/phpunit-code-quality.php';
 
+    public const string PHPUNIT_NARROW_ASSERTS = __DIR__ . '/../../config/sets/phpunit-narrow-asserts.php';
+
     public const string ANNOTATIONS_TO_ATTRIBUTES = __DIR__ . '/../../config/sets/annotations-to-attributes.php';
 }