[PHPUnit60] Skip Twig IntegrationTestCase children in AddDoesNotPerformAssertionToNonAssertingTestRector (#762)

Author: TomasVotruba

rules-tests/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector/Fixture/skip_twig_integration_test_case.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit60\Rector\ClassMethod\AddDoesNotPerformAssertionToNonAssertingTestRector\Fixture;
+
+use Twig\Test\IntegrationTestCase;
+
+final class SkipTwigIntegrationTestCase extends IntegrationTestCase
+{
+    public function testIntegration($file, $message, $condition, $templates, $exception, $outputs)
+    {
+        $this->doIntegrationTest($file, $message, $condition, $templates, $exception, $outputs);
+    }
+}

rules/PHPUnit60/Rector/ClassMethod/AddDoesNotPerformAssertionToNonAssertingTestRector.php

@@ -8,13 +8,16 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagNode;
+use PHPStan\Reflection\ClassReflection;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
 use Rector\Php80\NodeAnalyzer\PhpAttributeAnalyzer;
+use Rector\PHPUnit\Enum\PHPUnitClassName;
 use Rector\PHPUnit\NodeAnalyzer\AssertCallAnalyzer;
 use Rector\PHPUnit\NodeAnalyzer\MockedVariableAnalyzer;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\Rector\AbstractRector;
+use Rector\Reflection\ReflectionResolver;
 use Rector\VersionBonding\Contract\ComposerPackageConstraintInterface;
 use Rector\VersionBonding\ValueObject\ComposerPackageConstraint;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -43,6 +46,7 @@ public function __construct(
         private readonly PhpAttributeAnalyzer $phpAttributeAnalyzer,
         private readonly DocBlockUpdater $docBlockUpdater,
         private readonly PhpDocInfoFactory $phpDocInfoFactory,
+        private readonly ReflectionResolver $reflectionResolver,
     ) {
     }
 
@@ -122,6 +126,11 @@ private function shouldSkipClassMethod(ClassMethod $classMethod): bool
             return true;
         }
 
+        // the parent test case asserts in its own integration methods
+        if ($this->isInTwigIntegrationTestCase($classMethod)) {
+            return true;
+        }
+
         if ($this->hasAssertingAnnotationOrAttribute($classMethod)) {
             return true;
         }
@@ -134,6 +143,16 @@ private function shouldSkipClassMethod(ClassMethod $classMethod): bool
         return $this->mockedVariableAnalyzer->containsMockAsUsedVariable($classMethod);
     }
 
+    private function isInTwigIntegrationTestCase(ClassMethod $classMethod): bool
+    {
+        $classReflection = $this->reflectionResolver->resolveClassReflection($classMethod);
+        if (! $classReflection instanceof ClassReflection) {
+            return false;
+        }
+
+        return $classReflection->is(PHPUnitClassName::TWIG_INTEGRATION_TEST_CASE);
+    }
+
     private function hasAssertingAnnotationOrAttribute(ClassMethod $classMethod): bool
     {
         $phpDocInfo = $this->phpDocInfoFactory->createFromNodeOrEmpty($classMethod);

src/Enum/PHPUnitClassName.php

@@ -34,6 +34,8 @@ final class PHPUnitClassName
 
     public const string SYMFONY_TYPE_TEST_CASE = 'Symfony\Component\Form\Test\TypeTestCase';
 
+    public const string TWIG_INTEGRATION_TEST_CASE = 'Twig\Test\IntegrationTestCase';
+
     /**
      * @var string[]
      */

stubs/Twig/Test/IntegrationTestCase.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Twig\Test;
+
+use PHPUnit\Framework\TestCase;
+
+abstract class IntegrationTestCase extends TestCase
+{
+    /**
+     * @param array<string, string> $templates
+     * @param array<string> $outputs
+     */
+    protected function doIntegrationTest(
+        string $file,
+        string $message,
+        string $condition,
+        array $templates,
+        string $exception,
+        array $outputs,
+        string $deprecation = ''
+    ): void {
+    }
+}