[PHPUnit90] Handle named and unpacked preg_match() args in AssertRegExpRector (#820)

Author: alies-dev

rules-tests/PHPUnit90/Rector/MethodCall/AssertRegExpRector/Fixture/named_preg_match_args.php.inc

@@ -0,0 +1,33 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit90\Rector\MethodCall\AssertRegExpRector\Fixture;
+
+final class NamedPregMatchArgs extends \PHPUnit\Framework\TestCase
+{
+    public function testFoo(): void
+    {
+        $string = 'keys=1000';
+
+        $this->assertSame(1, preg_match(pattern: '/^keys=\d+/', subject: $string));
+        $this->assertSame(0, preg_match(subject: $string, pattern: '/^values=\d+/'));
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit90\Rector\MethodCall\AssertRegExpRector\Fixture;
+
+final class NamedPregMatchArgs extends \PHPUnit\Framework\TestCase
+{
+    public function testFoo(): void
+    {
+        $string = 'keys=1000';
+
+        $this->assertMatchesRegularExpression(pattern: '/^keys=\d+/', string: $string);
+        $this->assertDoesNotMatchRegularExpression(string: $string, pattern: '/^values=\d+/');
+    }
+}
+
+?>

rules-tests/PHPUnit90/Rector/MethodCall/AssertRegExpRector/Fixture/skip_unpacked_preg_match_args.php.inc

@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\PHPUnit90\Rector\MethodCall\AssertRegExpRector\Fixture;
+
+final class SkipUnpackedPregMatchArgs extends \PHPUnit\Framework\TestCase
+{
+    public function testFoo(array $args): void
+    {
+        $this->assertSame(1, preg_match(...$args));
+        $this->assertSame(1, preg_match('/^keys=\d+/', ...$args));
+    }
+}

rules/PHPUnit90/Rector/MethodCall/AssertRegExpRector.php

@@ -128,6 +128,10 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if (! $this->hasMovablePregMatchArgs($secondArgumentValue)) {
+                continue;
+            }
+
             if (! $this->testsNodeAnalyzer->isPHPUnitMethodCallNames(
                 $stmt->expr,
                 [self::ASSERT_SAME, self::ASSERT_EQUALS, self::ASSERT_NOT_SAME, self::ASSERT_NOT_EQUALS]
@@ -194,6 +198,16 @@ private function renameMethod(MethodCall|StaticCall $node, string $oldMethodName
         }
     }
 
+    private function hasMovablePregMatchArgs(FuncCall $funcCall): bool
+    {
+        $args = $funcCall->getArgs();
+        if (! isset($args[0], $args[1])) {
+            return false;
+        }
+
+        return array_all($args, fn ($arg): bool => ! $arg->unpack);
+    }
+
     private function moveFunctionArgumentsUp(MethodCall|StaticCall $node): void
     {
         $oldArguments = $node->getArgs();
@@ -204,6 +218,13 @@ private function moveFunctionArgumentsUp(MethodCall|StaticCall $node): void
         $regex = $pregMatchFunction->getArgs()[0];
         $variable = $pregMatchFunction->getArgs()[1];
 
+        // preg_match() names it $subject, PHPUnit names it $string
+        foreach ([$regex, $variable] as $arg) {
+            if ($arg->name instanceof Identifier && $this->isName($arg->name, 'subject')) {
+                $arg->name = new Identifier('string');
+            }
+        }
+
         unset($oldArguments[0], $oldArguments[1]);
 
         $node->args = [$regex, $variable, ...$oldArguments];