Repository navigation
Expand file tree
/
Copy pathLogicalToBooleanRector.php
More file actions
117 lines (102 loc) · 3.62 KB
/
Copy pathLogicalToBooleanRector.php
File metadata and controls
117 lines (102 loc) · 3.62 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
<?php
declare(strict_types=1);
namespace Rector\CodeQuality\Rector\LogicalAnd;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\AssignOp;
use PhpParser\Node\Expr\AssignRef;
use PhpParser\Node\Expr\BinaryOp;
use PhpParser\Node\Expr\BinaryOp\BooleanAnd;
use PhpParser\Node\Expr\BinaryOp\BooleanOr;
use PhpParser\Node\Expr\BinaryOp\LogicalAnd;
use PhpParser\Node\Expr\BinaryOp\LogicalOr;
use PhpParser\Node\Expr\BitwiseNot;
use PhpParser\Node\Expr\BooleanNot;
use PhpParser\Node\Expr\Cast;
use PhpParser\Node\Expr\ErrorSuppress;
use PhpParser\Node\Expr\UnaryMinus;
use PhpParser\Node\Expr\UnaryPlus;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\LogicalAnd\LogicalToBooleanRector\LogicalToBooleanRectorTest
*/
final class LogicalToBooleanRector extends AbstractRector
{
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Change OR, AND to ||, && with more common understanding',
[
new CodeSample(
<<<'CODE_SAMPLE'
if ($f = false or true) {
return $f;
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
if (($f = false) || true) {
return $f;
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [LogicalOr::class, LogicalAnd::class];
}
/**
* @param LogicalOr|LogicalAnd $node
*/
public function refactor(Node $node): BooleanAnd|BooleanOr|null
{
if ($node->left instanceof Assign) {
$type = $this->nodeTypeResolver->getNativeType($node->left);
if (! $type->isBoolean()->yes()) {
return null;
}
}
return $this->refactorLogicalToBoolean($node);
}
private function refactorLogicalToBoolean(LogicalOr|LogicalAnd $node): BooleanAnd|BooleanOr
{
if ($node->left instanceof LogicalOr || $node->left instanceof LogicalAnd) {
$node->left = $this->refactorLogicalToBoolean($node->left);
}
if ($node->right instanceof LogicalOr || $node->right instanceof LogicalAnd) {
$node->right = $this->refactorLogicalToBoolean($node->right);
}
// "and"/"or" bind looser than "="/"+="; once they become "&&"/"||" the assignment must be
// re-printed so the pretty-printer re-adds the parentheses that keep the original semantics
$this->reprintNestedAssign($node->left);
$this->reprintNestedAssign($node->right);
if ($node instanceof LogicalOr) {
return new BooleanOr($node->left, $node->right);
}
return new BooleanAnd($node->left, $node->right);
}
private function reprintNestedAssign(Expr $expr): void
{
if ($expr instanceof Assign || $expr instanceof AssignOp || $expr instanceof AssignRef) {
$expr->setAttribute(AttributeKey::ORIGINAL_NODE, null);
return;
}
if ($expr instanceof BooleanNot || $expr instanceof BitwiseNot || $expr instanceof UnaryMinus || $expr instanceof UnaryPlus || $expr instanceof ErrorSuppress || $expr instanceof Cast) {
$this->reprintNestedAssign($expr->expr);
return;
}
if ($expr instanceof BinaryOp) {
$this->reprintNestedAssign($expr->left);
$this->reprintNestedAssign($expr->right);
}
}
}