Repository navigation
Expand file tree
/
Copy pathArrayExplicitBoolCompareRector.php
More file actions
113 lines (98 loc) · 2.88 KB
/
Copy pathArrayExplicitBoolCompareRector.php
File metadata and controls
113 lines (98 loc) · 2.88 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
<?php
declare(strict_types=1);
namespace Rector\CodeQuality\Rector\If_;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\Array_;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\Ternary;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Stmt\ElseIf_;
use PhpParser\Node\Stmt\If_;
use Rector\CodeQuality\NodeAnalyzer\ExplicitBoolConditionResolver;
use Rector\CodeQuality\ValueObject\ExplicitBoolCondition;
use Rector\NodeTypeResolver\TypeAnalyzer\ArrayTypeAnalyzer;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\If_\ArrayExplicitBoolCompareRector\ArrayExplicitBoolCompareRectorTest
*/
final class ArrayExplicitBoolCompareRector extends AbstractRector
{
public function __construct(
private readonly ArrayTypeAnalyzer $arrayTypeAnalyzer,
private readonly ExplicitBoolConditionResolver $explicitBoolConditionResolver,
) {
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Make array if conditions more explicit', [
new CodeSample(
<<<'CODE_SAMPLE'
final class SomeController
{
public function run(array $items)
{
if (!$items) {
return 'no items';
}
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
final class SomeController
{
public function run(array $items)
{
if ($items === []) {
return 'no items';
}
}
}
CODE_SAMPLE
),
]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [If_::class, ElseIf_::class, Ternary::class];
}
/**
* @param If_|ElseIf_|Ternary $node
*/
public function refactor(Node $node): ?Node
{
$explicitBoolCondition = $this->explicitBoolConditionResolver->resolve($node);
if (! $explicitBoolCondition instanceof ExplicitBoolCondition) {
return null;
}
$expr = $explicitBoolCondition->getConditionNode();
if (! $this->arrayTypeAnalyzer->isArrayType($expr)) {
return null;
}
$binaryOp = $this->resolveArray($explicitBoolCondition->isNegated(), $expr);
if (! $binaryOp instanceof Expr) {
return null;
}
$node->cond = $binaryOp;
return $node;
}
private function resolveArray(bool $isNegated, Expr $expr): Identical|NotIdentical|null
{
if (! $expr instanceof Variable) {
return null;
}
$array = new Array_([]);
// compare === []
if ($isNegated) {
return new Identical($expr, $array);
}
return new NotIdentical($expr, $array);
}
}