Repository navigation
Expand file tree
/
Copy pathSimplifyQuoteEscapeRector.php
More file actions
182 lines (151 loc) · 5 KB
/
Copy pathSimplifyQuoteEscapeRector.php
File metadata and controls
182 lines (151 loc) · 5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
<?php
declare(strict_types=1);
namespace Rector\CodingStyle\Rector\String_;
use Nette\Utils\Validators;
use PhpParser\Node;
use PhpParser\Node\Scalar\String_;
use Rector\NodeTypeResolver\Node\AttributeKey;
use Rector\Rector\AbstractRector;
use Rector\RuleDoc\CodeSample\CodeSample;
use Rector\RuleDoc\RuleDefinition;
use Rector\Util\StringUtils;
/**
* @see \Rector\Tests\CodingStyle\Rector\String_\SimplifyQuoteEscapeRector\SimplifyQuoteEscapeRectorTest
*/
final class SimplifyQuoteEscapeRector extends AbstractRector
{
/**
* @see https://regex101.com/r/qEkCe9/2
*/
private const string ESCAPED_CHAR_REGEX = '#\\\\|\$|\\n|\\t#sim';
/**
* @see https://alvinalexander.com/php/how-to-remove-non-printable-characters-in-string-regex/
* @see https://regex101.com/r/lGUhRb/1
*/
private const string HAS_NON_PRINTABLE_CHARS = '#[\x00-\x1F\x80-\xFF]#';
/**
* @see https://regex101.com/r/tY7eKW/1
*/
private const string CONTROL_CHARS_REGEX = '#[\x00-\x1F]#';
private bool $hasChanged = false;
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Prefer quote that are not inside the string',
[
new CodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
$name = "\" Tom";
$name = '\' Sara';
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
$name = '" Tom';
$name = "' Sara";
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [String_::class];
}
/**
* @param String_ $node
*/
public function refactor(Node $node): ?String_
{
$this->hasChanged = false;
$doubleQuoteCount = substr_count($node->value, '"');
$singleQuoteCount = substr_count($node->value, "'");
// no quotes to simplify
if ($doubleQuoteCount === 0 && $singleQuoteCount === 0) {
return null;
}
if ($this->hasNonPrintableChars($node->value)) {
return null;
}
$kind = $node->getAttribute(AttributeKey::KIND);
if ($kind === String_::KIND_SINGLE_QUOTED) {
$this->processSingleQuoted($node, $doubleQuoteCount, $singleQuoteCount);
}
$quoteKind = $node->getAttribute(AttributeKey::KIND);
if ($quoteKind === String_::KIND_DOUBLE_QUOTED) {
$this->processDoubleQuoted($node, $singleQuoteCount, $doubleQuoteCount);
}
if (! $this->hasChanged) {
return null;
}
return $node;
}
private function processSingleQuoted(String_ $string, int $doubleQuoteCount, int $singleQuoteCount): void
{
if ($doubleQuoteCount === 0 && $singleQuoteCount > 0) {
// contains chars that will be newly escaped
if ($this->isMatchEscapedChars($string->value)) {
return;
}
$string->setAttribute(AttributeKey::KIND, String_::KIND_DOUBLE_QUOTED);
// invoke override
$string->setAttribute(AttributeKey::ORIGINAL_NODE, null);
$this->hasChanged = true;
}
}
private function processDoubleQuoted(String_ $string, int $singleQuoteCount, int $doubleQuoteCount): void
{
if ($singleQuoteCount === 0 && $doubleQuoteCount > 0) {
// contains chars that will be newly escaped
if ($this->isMatchEscapedChars($string->value)) {
return;
}
// contains escape sequence that will be printed as raw char, e.g. "\u{00A0}"
if ($this->hasEscapeSequence($string)) {
return;
}
$string->setAttribute(AttributeKey::KIND, String_::KIND_SINGLE_QUOTED);
// invoke override
$string->setAttribute(AttributeKey::ORIGINAL_NODE, null);
$this->hasChanged = true;
}
}
private function isMatchEscapedChars(string $string): bool
{
return StringUtils::isMatch($string, self::ESCAPED_CHAR_REGEX);
}
private function hasEscapeSequence(String_ $string): bool
{
$rawValue = $string->getAttribute(AttributeKey::RAW_VALUE);
if (! is_string($rawValue)) {
return false;
}
// any escape sequence other than \" makes the written content differ from the value
return str_replace('\\"', '"', substr($rawValue, 1, -1)) !== $string->value;
}
private function hasNonPrintableChars(string $value): bool
{
if (! StringUtils::isMatch($value, self::HAS_NON_PRINTABLE_CHARS)) {
return false;
}
if (StringUtils::isMatch($value, self::CONTROL_CHARS_REGEX)) {
return true;
}
// bytes above ASCII are printable as part of valid UTF-8 text, e.g. "é"
return ! Validators::isUnicode($value);
}
}