Repository navigation
Expand file tree
/
Copy pathThisCallOnStaticMethodToStaticCallRector.php
More file actions
183 lines (153 loc) · 4.76 KB
/
Copy pathThisCallOnStaticMethodToStaticCallRector.php
File metadata and controls
183 lines (153 loc) · 4.76 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
<?php
declare(strict_types=1);
namespace Rector\Php70\Rector\MethodCall;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Identifier;
use PhpParser\Node\Scalar\InterpolatedString;
use PhpParser\Node\Stmt\Class_;
use PhpParser\NodeVisitor;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Reflection\Php\PhpMethodReflection;
use Rector\Enum\ObjectReference;
use Rector\NodeCollector\StaticAnalyzer;
use Rector\Rector\AbstractRector;
use Rector\Reflection\ReflectionResolver;
use Rector\RuleDoc\CodeSample\CodeSample;
use Rector\RuleDoc\RuleDefinition;
use Rector\ValueObject\PhpVersionFeature;
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
/**
* @see \Rector\Tests\Php70\Rector\MethodCall\ThisCallOnStaticMethodToStaticCallRector\ThisCallOnStaticMethodToStaticCallRectorTest
*/
final class ThisCallOnStaticMethodToStaticCallRector extends AbstractRector implements MinPhpVersionInterface
{
private bool $hasChanged = false;
public function __construct(
private readonly StaticAnalyzer $staticAnalyzer,
private readonly ReflectionResolver $reflectionResolver,
) {
}
public function provideMinPhpVersion(): int
{
return PhpVersionFeature::STATIC_CALL_ON_NON_STATIC;
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'Changes $this->call() to static method to static call',
[
new CodeSample(
<<<'CODE_SAMPLE'
class SomeClass
{
public static function run()
{
$this->eat();
}
public static function eat()
{
}
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
class SomeClass
{
public static function run()
{
static::eat();
}
public static function eat()
{
}
}
CODE_SAMPLE
),
]
);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node): ?Node
{
$classReflection = $this->fetchClassLikeReflection($node);
if (! $classReflection instanceof ClassReflection) {
return null;
}
// skip PHPUnit calls, as they accept both self:: and $this-> formats
if ($classReflection->is('PHPUnit\Framework\TestCase')) {
return null;
}
$this->hasChanged = false;
$this->processThisToStatic($node, $classReflection);
if ($this->hasChanged) {
return $node;
}
return null;
}
private function processThisToStatic(Class_ $class, ClassReflection $classReflection): void
{
$this->traverseNodesWithCallable($class, function (Node $subNode) use (
$class,
$classReflection
): null|StaticCall|int {
if ($subNode instanceof InterpolatedString) {
return NodeVisitor::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
}
if (! $subNode instanceof MethodCall) {
return null;
}
if (! $subNode->var instanceof Variable) {
return null;
}
if (! $this->isName($subNode->var, 'this')) {
return null;
}
if (! $subNode->name instanceof Identifier) {
return null;
}
$methodName = $this->getName($subNode->name);
if ($methodName === null) {
return null;
}
if ($subNode->isFirstClassCallable()) {
return null;
}
$isStaticMethod = $this->staticAnalyzer->isStaticMethod($classReflection, $methodName, $class);
if (! $isStaticMethod) {
return null;
}
$this->hasChanged = true;
$objectReference = $this->resolveClassSelf($class, $subNode);
return $this->nodeFactory->createStaticCall($objectReference, $methodName, $subNode->args);
});
}
/**
* @return ObjectReference::STATIC|ObjectReference::SELF
*/
private function resolveClassSelf(Class_ $class, MethodCall $methodCall): string
{
if ($class->isFinal()) {
return ObjectReference::SELF;
}
$methodReflection = $this->reflectionResolver->resolveMethodReflectionFromMethodCall($methodCall);
if (! $methodReflection instanceof PhpMethodReflection) {
return ObjectReference::STATIC;
}
if (! $methodReflection->isPrivate()) {
return ObjectReference::STATIC;
}
return ObjectReference::SELF;
}
}