rector-src/rules/CodeQuality/Rector/Ternary/NumberCompareToMaxFuncCallRector.php at fc7a47fa08560f3bdbf9ea45b9fb6fb4cdfabbfe · rectorphp/rector-src · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
<?php

declare(strict_types=1);

namespace Rector\CodeQuality\Rector\Ternary;

use PhpParser\Node;
use PhpParser\Node\Expr\BinaryOp;
use PhpParser\Node\Expr\BinaryOp\Greater;
use PhpParser\Node\Expr\BinaryOp\GreaterOrEqual;
use PhpParser\Node\Expr\BinaryOp\Smaller;
use PhpParser\Node\Expr\BinaryOp\SmallerOrEqual;
use PhpParser\Node\Expr\Ternary;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

/**
 * @see \Rector\Tests\CodeQuality\Rector\Ternary\NumberCompareToMaxFuncCallRector\NumberCompareToMaxFuncCallRectorTest
 */
final class NumberCompareToMaxFuncCallRector extends AbstractRector
{
    public function getRuleDefinition(): RuleDefinition
    {
        return new RuleDefinition('Change ternary number compare to `max()` call', [
            new CodeSample(
                <<<'CODE_SAMPLE'
class SomeClass
{
    public function run($value)
    {
        return $value > 100 ? $value : 100;
    }
}
CODE_SAMPLE

                ,
                <<<'CODE_SAMPLE'
class SomeClass
{
    public function run($value)
    {
        return max($value, 100);
    }
}
CODE_SAMPLE
            ),
        ]);
    }

    /**
     * @return array<class-string<Node>>
     */
    public function getNodeTypes(): array
    {
        return [Ternary::class];
    }

    /**
     * @param Ternary $node
     */
    public function refactor(Node $node): ?Node
    {
        if (! $node->cond instanceof BinaryOp) {
            return null;
        }

        $binaryOp = $node->cond;

        if ($binaryOp instanceof Smaller || $binaryOp instanceof SmallerOrEqual) {
            if (! $this->nodeComparator->areNodesEqual($binaryOp->left, $node->else)) {
                return null;
            }

            if (! $this->nodeComparator->areNodesEqual($binaryOp->right, $node->if)) {
                return null;
            }

            if (! $this->areIntegersCompared($binaryOp)) {
                return null;
            }

            return $this->nodeFactory->createFuncCall('max', [$node->if, $node->else]);
        }

        if ($binaryOp instanceof Greater || $binaryOp instanceof GreaterOrEqual) {
            if (! $this->nodeComparator->areNodesEqual($binaryOp->left, $node->if)) {
                return null;
            }

            if (! $this->nodeComparator->areNodesEqual($binaryOp->right, $node->else)) {
                return null;
            }

            if (! $this->areIntegersCompared($binaryOp)) {
                return null;
            }

            return $this->nodeFactory->createFuncCall('max', [$node->if, $node->else]);
        }

        return null;
    }

    private function areIntegersCompared(BinaryOp $binaryOp): bool
    {
        $leftType = $this->getType($binaryOp->left);
        if (! $leftType->isInteger()->yes()) {
            return false;
        }

        $rightType = $this->getType($binaryOp->right);
        return $rightType->isInteger()
            ->yes();
    }
}