[dx] Add getClassReflection() to AbstractRector, use it in Class_ node rules (#8827)

Co-authored-by: GitHub Action <actions@github.com>

Author: TomasVotruba

rules-tests/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector/Fixture/keep_create_component.php.inc

@@ -77,12 +77,17 @@ public function refactor(Node $node): ?Class_
     {
         $hasChanged = false;
         $isFinal = $node->isFinal() || FeatureFlags::treatClassesAsFinal($node);
+
         $scope = null;
-        $classReflection = null;
+
+        $classReflection = $this->getClassReflection($node);
+        if (! $classReflection instanceof ClassReflection) {
+            return null;
+        }
 
         $this->traverseNodesWithCallable($node->stmts, function (Node $subNode) use (
             &$hasChanged,
-            &$classReflection,
+            $classReflection,
             $isFinal,
             &$scope,
             $node,
@@ -108,11 +113,6 @@ public function refactor(Node $node): ?Class_
             }
 
             $scope ??= ScopeFetcher::fetch($node);
-            $classReflection ??= $scope->getClassReflection();
-
-            if (! $classReflection instanceof ClassReflection) {
-                return null;
-            }
 
             if ($this->shouldSkip($subNode, $classReflection, $isFinal, $scope)) {
                 return null;

rules/CodeQuality/Rector/Class_/ConvertStaticToSelfRector.php

@@ -10,7 +10,6 @@
 use PhpParser\Node\Stmt\Enum_;
 use PHPStan\Reflection\ClassReflection;
 use Rector\NodeManipulator\ClassConstManipulator;
-use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
 use Rector\Reflection\ReflectionResolver;
 use Rector\RuleDoc\CodeSample\CodeSample;
@@ -78,7 +77,7 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
-            if ($this->shouldSkipClassConst($stmt)) {
+            if ($this->shouldSkipClassConst($classReflection, $stmt)) {
                 continue;
             }
 
@@ -101,7 +100,7 @@ public function refactor(Node $node): ?Node
         return $node;
     }
 
-    private function shouldSkipClassConst(ClassConst $classConst): bool
+    private function shouldSkipClassConst(ClassReflection $classReflection, ClassConst $classConst): bool
     {
         if (! $classConst->isPrivate()) {
             return true;
@@ -111,13 +110,6 @@ private function shouldSkipClassConst(ClassConst $classConst): bool
             return true;
         }
 
-        $scope = ScopeFetcher::fetch($classConst);
-
-        $classReflection = $scope->getClassReflection();
-        if (! $classReflection instanceof ClassReflection) {
-            return false;
-        }
-
         return $this->hasParentClassOfEnumSuffix($classReflection);
     }
 

rules/DeadCode/Rector/ClassConst/RemoveUnusedPrivateClassConstantRector.php

@@ -16,7 +16,6 @@
 use PHPStan\Type\ObjectType;
 use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
 use Rector\PhpParser\Node\Value\ValueResolver;
-use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
 use Rector\RuleDoc\CodeSample\CodeSample;
 use Rector\RuleDoc\RuleDefinition;
@@ -91,9 +90,7 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        $scope = ScopeFetcher::fetch($node);
-        $classReflection = $scope->getClassReflection();
-
+        $classReflection = $this->getClassReflection($node);
         if (! $classReflection instanceof ClassReflection) {
             return null;
         }

rules/DeadCode/Rector/Class_/RemoveRefactorDuplicatedNodeInstanceCheckRector.php

@@ -92,7 +92,7 @@ public function refactor(Node $node): Class_|null
             return null;
         }
 
-        $classReflection = $scope->getClassReflection();
+        $classReflection = $this->getClassReflection($node);
         if (! $classReflection instanceof ClassReflection) {
             return null;
         }

rules/Php70/Rector/ClassMethod/Php4ConstructorRector.php

@@ -16,7 +16,6 @@
 use PHPStan\Reflection\Php\PhpMethodReflection;
 use Rector\Enum\ObjectReference;
 use Rector\NodeCollector\StaticAnalyzer;
-use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
 use Rector\Reflection\ReflectionResolver;
 use Rector\RuleDoc\CodeSample\CodeSample;
@@ -93,13 +92,11 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        $scope = ScopeFetcher::fetch($node);
-        if (! $scope->isInClass()) {
+        $classReflection = $this->getClassReflection($node);
+        if (! $classReflection instanceof ClassReflection) {
             return null;
         }
 
-        $classReflection = $scope->getClassReflection();
-
         // skip PHPUnit calls, as they accept both self:: and $this-> formats
         if ($classReflection->is('PHPUnit\Framework\TestCase')) {
             return null;

rules/Php70/Rector/MethodCall/ThisCallOnStaticMethodToStaticCallRector.php

@@ -26,7 +26,6 @@
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\PhpParser\Printer\BetterStandardPrinter;
-use Rector\PHPStan\ScopeFetcher;
 use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
 use Rector\Rector\AbstractRector;
 use Rector\RuleDoc\CodeSample\CodeSample;
@@ -113,6 +112,11 @@ public function refactor(Node $node): ?Node
 
         $hasChanged = false;
 
+        $classReflection = $this->getClassReflection($node);
+        if (! $classReflection instanceof ClassReflection) {
+            return null;
+        }
+
         foreach ($node->getMethods() as $classMethod) {
             if ($this->isName($classMethod, MethodName::CONSTRUCT)) {
                 continue;
@@ -127,14 +131,11 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
-            $scope = ScopeFetcher::fetch($node);
-            $currentClassReflection = $scope->getClassReflection();
-
             // It relies on phpstorm stubs that define 2 kind of query method for both php 7.4 and php 8.0
             // @see https://github.com/JetBrains/phpstorm-stubs/blob/e2e898a29929d2f520fe95bdb2109d8fa895ba4a/PDO/PDO.php#L1096-L1126
             if ($parentMethodReflection->getName() === 'query'
-                && $currentClassReflection instanceof ClassReflection
-                && $currentClassReflection->is('PDO')) {
+                // && $classReflection instanceof ClassReflection
+                && $classReflection->is('PDO')) {
                 continue;
             }
 

rules/Php80/Rector/ClassMethod/AddParamBasedOnParentClassMethodRector.php

@@ -8,7 +8,6 @@
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassConst;
 use PHPStan\Reflection\ClassReflection;
-use Rector\PHPStan\ScopeFetcher;
 use Rector\Privatization\Guard\OverrideByParentClassGuard;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
 use Rector\Rector\AbstractRector;
@@ -68,8 +67,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $scope = ScopeFetcher::fetch($node);
-        $classReflection = $scope->getClassReflection();
+        $classReflection = $this->getClassReflection($node);
         if (! $classReflection instanceof ClassReflection) {
             return null;
         }

rules/Privatization/Rector/ClassConst/PrivatizeFinalClassConstantRector.php

@@ -10,7 +10,6 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Reflection\ClassReflection;
 use Rector\PhpParser\Node\BetterNodeFinder;
-use Rector\PHPStan\ScopeFetcher;
 use Rector\Privatization\Guard\LaravelModelGuard;
 use Rector\Privatization\Guard\OverrideByParentClassGuard;
 use Rector\Privatization\Guard\ParentClassMagicCallGuard;
@@ -80,14 +79,12 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if (! $this->overrideByParentClassGuard->isLegal($node)) {
+        $classReflection = $this->getClassReflection($node);
+        if (! $classReflection instanceof ClassReflection) {
             return null;
         }
 
-        $scope = ScopeFetcher::fetch($node);
-
-        $classReflection = $scope->getClassReflection();
-        if (! $classReflection instanceof ClassReflection) {
+        if (! $this->overrideByParentClassGuard->isLegal($node)) {
             return null;
         }
 
@@ -133,13 +130,6 @@ public function refactor(Node $node): ?Node
 
     private function shouldSkipClassMethod(ClassMethod $classMethod): bool
     {
-        // edge case in nette framework
-        /** @var string $methodName */
-        $methodName = $this->getName($classMethod->name);
-        if (str_starts_with($methodName, 'createComponent')) {
-            return true;
-        }
-
         if (! $classMethod->isProtected()) {
             return true;
         }
@@ -149,7 +139,7 @@ private function shouldSkipClassMethod(ClassMethod $classMethod): bool
         }
 
         // if has parent call, its probably overriding parent one → skip it
-        $hasParentCall = (bool) $this->betterNodeFinder->findFirst(
+        return (bool) $this->betterNodeFinder->findFirst(
             (array) $classMethod->stmts,
             function (Node $node): bool {
                 if (! $node instanceof StaticCall) {
@@ -159,7 +149,5 @@ function (Node $node): bool {
                 return $this->isName($node->class, 'parent');
             }
         );
-
-        return $hasParentCall;
     }
 }

rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php

@@ -12,7 +12,6 @@
 use PhpParser\Node\Stmt\Property;
 use PHPStan\Reflection\ClassReflection;
 use Rector\Php74\Guard\MakePropertyTypedGuard;
-use Rector\PHPStan\ScopeFetcher;
 use Rector\Rector\AbstractRector;
 use Rector\RuleDoc\CodeSample\CodeSample;
 use Rector\RuleDoc\RuleDefinition;
@@ -83,9 +82,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        $scope = ScopeFetcher::fetch($node);
-
-        $classReflection = $scope->getClassReflection();
+        $classReflection = $this->getClassReflection($node);
         if (! $classReflection instanceof ClassReflection) {
             return null;
         }