Skip to content

Commit 1598dd7

Browse files
committed
[dx] Deprecate ExplicitBoolCompareRector
Array and object bool compares have dedicated rules; the remaining behavior is an opinionated approach that depends on context. Replace the body with a deprecation message, remove its tests, and unregister it from the if set. Claude-Session: https://claude.ai/code/session_012HQ19gVsT8wVkekuVqVXGx
1 parent ac496d5 commit 1598dd7

20 files changed

Lines changed: 9 additions & 803 deletions

‎config/set/if.php‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
use Rector\CodeQuality\Rector\If_\ArrayExplicitBoolCompareRector;
88
use Rector\CodeQuality\Rector\If_\CombineIfRector;
99
use Rector\CodeQuality\Rector\If_\CompleteMissingIfElseBracketRector;
10-
use Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector;
1110
use Rector\CodeQuality\Rector\If_\ObjectExplicitBoolCompareRector;
1211
use Rector\CodeQuality\Rector\If_\ShortenElseIfRector;
1312
use Rector\CodeQuality\Rector\If_\SimplifyIfElseToTernaryRector;
@@ -22,7 +21,6 @@
2221
TernaryFalseExpressionToIfRector::class,
2322
ArrayExplicitBoolCompareRector::class,
2423
ObjectExplicitBoolCompareRector::class,
25-
ExplicitBoolCompareRector::class,
2624
CombineIfRector::class,
2725
ShortenElseIfRector::class,
2826
SimplifyIfElseToTernaryRector::class,

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/ExplicitBoolCompareRectorTest.php‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/count.php.inc‎

Lines changed: 0 additions & 35 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/explode.php.inc‎

Lines changed: 0 additions & 37 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/if_assign_cond.php.inc‎

Lines changed: 0 additions & 36 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/numbers.php.inc‎

Lines changed: 0 additions & 53 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/phpstan_0_12_6break.php.inc‎

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/skip_if_else.php.inc‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/skip_nested_array_mixed.php.inc‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/skip_phpdoc-typed.php.inc‎

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)