[Composer] Target lowest version for any distributed package type, only 'project' is an application

Author: TomasVotruba

src/Composer/InstalledPackageResolver.php

@@ -137,12 +137,16 @@ private function createInstalledPackages(array $packages): array
     /**
      * A library declares a compatibility range in its "composer.json"; the version-specific rules must target the
      * lowest declared version, not the one that happens to be installed locally.
+     *
+     * Anything but an application counts as a library: a missing "type" or an explicit "project" is an application,
+     * every other declared type ("library", "symfony-bundle", ...) is a distributed package.
      */
     private function isLibrary(): bool
     {
         $projectComposerJson = $this->loadProjectComposerJson();
+        $type = $projectComposerJson['type'] ?? null;
 
-        return ($projectComposerJson['type'] ?? null) === 'library';
+        return is_string($type) && $type !== 'project';
     }
 
     /**

tests/Composer/Fixture/InstalledPackageResolver/project_composer_json/composer.json

@@ -0,0 +1,10 @@
+{
+    "type": "project",
+    "require": {
+        "phpunit/phpunit": "^10.5 || ^11.0 || ^12.0",
+        "symfony/console": "^7.0"
+    },
+    "require-dev": {
+        "nette/utils": "^3.2"
+    }
+}

tests/Composer/Fixture/InstalledPackageResolver/project_composer_json/vendor/composer/installed.json

@@ -0,0 +1,24 @@
+{
+    "packages": [
+        {
+            "name": "phpunit/phpunit",
+            "version": "12.1.0",
+            "version_normalized": "12.1.0.0"
+        },
+        {
+            "name": "symfony/console",
+            "version": "v7.2.0",
+            "version_normalized": "7.2.0.0"
+        },
+        {
+            "name": "nette/utils",
+            "version": "v3.2.0",
+            "version_normalized": "3.2.0.0"
+        },
+        {
+            "name": "webmozart/assert",
+            "version": "1.11.0",
+            "version_normalized": "1.11.0.0"
+        }
+    ]
+}

tests/Composer/Fixture/InstalledPackageResolver/symfony_bundle_composer_json/composer.json

@@ -0,0 +1,10 @@
+{
+    "type": "symfony-bundle",
+    "require": {
+        "phpunit/phpunit": "^10.5 || ^11.0 || ^12.0",
+        "symfony/console": "^7.0"
+    },
+    "require-dev": {
+        "nette/utils": "^3.2"
+    }
+}

tests/Composer/Fixture/InstalledPackageResolver/symfony_bundle_composer_json/vendor/composer/installed.json

@@ -0,0 +1,24 @@
+{
+    "packages": [
+        {
+            "name": "phpunit/phpunit",
+            "version": "12.1.0",
+            "version_normalized": "12.1.0.0"
+        },
+        {
+            "name": "symfony/console",
+            "version": "v7.2.0",
+            "version_normalized": "7.2.0.0"
+        },
+        {
+            "name": "nette/utils",
+            "version": "v3.2.0",
+            "version_normalized": "3.2.0.0"
+        },
+        {
+            "name": "webmozart/assert",
+            "version": "1.11.0",
+            "version_normalized": "1.11.0.0"
+        }
+    ]
+}

tests/Composer/InstalledPackageResolverTest.php

@@ -4,6 +4,7 @@
 
 namespace Rector\Tests\Composer;
 
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Rector\Composer\InstalledPackageResolver;
 use Rector\Composer\ValueObject\InstalledPackage;
@@ -47,11 +48,10 @@ public function testComposerJsonHasPriorityOverOutdatedInstalledJson(): void
         $this->assertSame('1.11.0.0', $installedPackageResolver->resolvePackageVersion('webmozart/assert'));
     }
 
-    public function testLibraryTargetsLowestDeclaredVersionEvenWhenInstalledSatisfies(): void
+    #[DataProvider('provideLibraryTypeFixtureDirectory')]
+    public function testLibraryTargetsLowestDeclaredVersionEvenWhenInstalledSatisfies(string $fixtureDirectory): void
     {
-        $installedPackageResolver = new InstalledPackageResolver(
-            __DIR__ . '/Fixture/InstalledPackageResolver/library_composer_json'
-        );
+        $installedPackageResolver = new InstalledPackageResolver($fixtureDirectory);
 
         // installed 12.1.0 satisfies "^10.5 || ^11.0 || ^12.0", yet a library targets the lowest declared version
         $this->assertSame('10.5.0.0', $installedPackageResolver->resolvePackageVersion('phpunit/phpunit'));
@@ -66,6 +66,31 @@ public function testLibraryTargetsLowestDeclaredVersionEvenWhenInstalledSatisfie
         $this->assertSame('1.11.0.0', $installedPackageResolver->resolvePackageVersion('webmozart/assert'));
     }
 
+    /**
+     * @return iterable<string, array{string}>
+     */
+    public static function provideLibraryTypeFixtureDirectory(): iterable
+    {
+        // "library" is the default distributed type
+        yield 'library' => [__DIR__ . '/Fixture/InstalledPackageResolver/library_composer_json'];
+
+        // any other non-"project" distributed type behaves the same way
+        yield 'symfony-bundle' => [__DIR__ . '/Fixture/InstalledPackageResolver/symfony_bundle_composer_json'];
+    }
+
+    public function testProjectTypeKeepsInstalledVersionOverDeclaredRange(): void
+    {
+        $installedPackageResolver = new InstalledPackageResolver(
+            __DIR__ . '/Fixture/InstalledPackageResolver/project_composer_json'
+        );
+
+        // an explicit "project" is an application, so the installed version stands even within a wider range
+        $this->assertSame('12.1.0.0', $installedPackageResolver->resolvePackageVersion('phpunit/phpunit'));
+
+        // installed 7.2.0 satisfies "^7.0", kept as installed
+        $this->assertSame('7.2.0.0', $installedPackageResolver->resolvePackageVersion('symfony/console'));
+    }
+
     public function testStandaloneComposerJsonResolvesVersionsWithoutVendor(): void
     {
         $installedPackageResolver = new InstalledPackageResolver(