Skip to content

Commit 4acfa67

Browse files
committed
[EarlyReturn] Deprecate ChangeOrIfContinueToMultiContinueRector
Splitting a single || condition into multiple continue ifs makes code longer and harder to read in most cases. Removed from early-return set.
1 parent 1949c3d commit 4acfa67

13 files changed

Lines changed: 9 additions & 442 deletions

File tree

‎config/set/early-return.php‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
77
use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
88
use Rector\EarlyReturn\Rector\If_\ChangeNestedIfsToEarlyReturnRector;
9-
use Rector\EarlyReturn\Rector\If_\ChangeOrIfContinueToMultiContinueRector;
109
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
1110
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
1211
use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
@@ -18,7 +17,6 @@
1817
ChangeIfElseValueAssignToEarlyReturnRector::class,
1918
ChangeNestedIfsToEarlyReturnRector::class,
2019
RemoveAlwaysElseRector::class,
21-
ChangeOrIfContinueToMultiContinueRector::class,
2220
PreparedValueToEarlyReturnRector::class,
2321
ReturnBinaryOrToEarlyReturnRector::class,
2422
ReturnEarlyIfVariableRector::class,

‎rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/ChangeOrIfContinueToMultiContinueRectorTest.php‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

‎rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/fixture.php.inc‎

Lines changed: 0 additions & 42 deletions
This file was deleted.

‎rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/has_comment.php.inc‎

Lines changed: 0 additions & 44 deletions
This file was deleted.

‎rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/many_and.php.inc‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/negated.php.inc‎

Lines changed: 0 additions & 45 deletions
This file was deleted.

‎rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/not_identical.php.inc‎

Lines changed: 0 additions & 42 deletions
This file was deleted.

‎rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/skip_and.php.inc‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

‎rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/skip_multi_stmts.php.inc‎

Lines changed: 0 additions & 21 deletions
This file was deleted.

‎rules-tests/EarlyReturn/Rector/If_/ChangeOrIfContinueToMultiContinueRector/Fixture/skip_not_continue.php.inc‎

Lines changed: 0 additions & 20 deletions
This file was deleted.

0 commit comments

Comments
 (0)