refactor: extract AutoloadFileParameterResolver from bin, add tests (#8035)

Follow-up to #8034, which merged before its last revision: the parameter
registration moves from inline bin code into a unit-testable class. Tests
pin that every CLI spelling (--autoload-file path, --autoload-file=path,
-a path) resolves to the same real path, that the parameter stays
untouched without the flag, and that registering it changes
FileHashComputer's configuration hash.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Author: SanderMuller

bin/rector.php

@@ -3,10 +3,10 @@
 declare(strict_types=1);
 
 use Nette\Utils\Json;
+use Rector\Bootstrap\AutoloadFileParameterResolver;
 use Rector\Bootstrap\RectorConfigsResolver;
 use Rector\ChangesReporting\Output\JsonOutputFormatter;
 use Rector\Configuration\Option;
-use Rector\Configuration\Parameter\SimpleParameterProvider;
 use Rector\Console\Style\SymfonyStyleFactory;
 use Rector\DependencyInjection\LazyContainerFactory;
 use Rector\DependencyInjection\RectorContainerFactory;
@@ -128,13 +128,7 @@ public function loadIfExistsAndNotLoadedYet(string $filePath): void
 $autoloadIncluder->autoloadRectorInstalledAsGlobalDependency();
 $autoloadIncluder->autoloadFromCommandLine();
 
-// a different extra autoload changes what PHPStan can resolve, so cached results
-// must not survive it: register it before the configuration hash is computed.
-// ArgvInput handles both "--autoload-file path" and "--autoload-file=path"
-$autoloadFileOption = (new ArgvInput())->getParameterOption(['--autoload-file', '-a'], null);
-if (is_string($autoloadFileOption) && $autoloadFileOption !== '') {
-    SimpleParameterProvider::setParameter(Option::AUTOLOAD_FILE, realpath($autoloadFileOption) ?: $autoloadFileOption);
-}
+AutoloadFileParameterResolver::resolveFromArgv($_SERVER['argv']);
 
 $rectorConfigsResolver = new RectorConfigsResolver();
 

src/Bootstrap/AutoloadFileParameterResolver.php

@@ -0,0 +1,37 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Bootstrap;
+
+use Rector\Configuration\Option;
+use Rector\Configuration\Parameter\SimpleParameterProvider;
+use Symfony\Component\Console\Input\ArgvInput;
+
+/**
+ * A different extra autoload changes what PHPStan can resolve, so cached results
+ * must not survive it. Registering the file as a parameter folds it into the
+ * configuration hash, which invalidates the cache like any other config change.
+ *
+ * Called from bin/rector.php before the configuration hash is computed.
+ *
+ * @see \Rector\Tests\Bootstrap\AutoloadFileParameterResolverTest
+ */
+final class AutoloadFileParameterResolver
+{
+    /**
+     * @param array<int, mixed> $argv
+     */
+    public static function resolveFromArgv(array $argv): void
+    {
+        // handles "--autoload-file path", "--autoload-file=path" and "-a path";
+        // parallel workers receive the space-separated form, so all spellings must
+        // normalize to the same value or main process and workers would disagree
+        $autoloadFile = (new ArgvInput($argv))->getParameterOption(['--autoload-file', '-a'], null);
+        if (! is_string($autoloadFile) || $autoloadFile === '') {
+            return;
+        }
+
+        SimpleParameterProvider::setParameter(Option::AUTOLOAD_FILE, realpath($autoloadFile) ?: $autoloadFile);
+    }
+}

tests/Bootstrap/AutoloadFileParameterResolverTest.php

@@ -0,0 +1,70 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Bootstrap;
+
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\TestCase;
+use Rector\Bootstrap\AutoloadFileParameterResolver;
+use Rector\Caching\Config\FileHashComputer;
+use Rector\Configuration\Option;
+use Rector\Configuration\Parameter\SimpleParameterProvider;
+
+final class AutoloadFileParameterResolverTest extends TestCase
+{
+    protected function setUp(): void
+    {
+        SimpleParameterProvider::setParameter(Option::AUTOLOAD_FILE, '');
+    }
+
+    /**
+     * all spellings must resolve to the same value, or the main process and
+     * parallel workers, which receive the space-separated form, would compute
+     * different configuration hashes
+     *
+     * @param array<int, string> $argv
+     */
+    #[DataProvider('provideArgvSpellings')]
+    public function testEverySpellingResolvesToSameRealPath(array $argv): void
+    {
+        AutoloadFileParameterResolver::resolveFromArgv($argv);
+
+        $this->assertSame(
+            (string) realpath(__FILE__),
+            SimpleParameterProvider::provideStringParameter(Option::AUTOLOAD_FILE)
+        );
+    }
+
+    /**
+     * @return iterable<string, array{array<int, string>}>
+     */
+    public static function provideArgvSpellings(): iterable
+    {
+        $relativePath = 'tests/Bootstrap/' . basename(__FILE__);
+
+        yield 'long with space' => [['bin/rector', 'process', '--autoload-file', __FILE__]];
+        yield 'long with equals' => [['bin/rector', 'process', '--autoload-file=' . __FILE__]];
+        yield 'short with space' => [['bin/rector', 'process', '-a', __FILE__]];
+        yield 'relative path is normalized' => [['bin/rector', 'process', '-a', $relativePath]];
+    }
+
+    public function testWithoutOptionParameterStaysUntouched(): void
+    {
+        AutoloadFileParameterResolver::resolveFromArgv(['bin/rector', 'process', '--dry-run']);
+
+        $this->assertSame('', SimpleParameterProvider::provideStringParameter(Option::AUTOLOAD_FILE));
+    }
+
+    public function testResolvedAutoloadFileChangesConfigurationHash(): void
+    {
+        $fileHashComputer = new FileHashComputer();
+        $configFilePath = __DIR__ . '/config/some_config.php';
+
+        $hashWithout = $fileHashComputer->compute($configFilePath);
+
+        AutoloadFileParameterResolver::resolveFromArgv(['bin/rector', 'process', '-a', __FILE__]);
+
+        $this->assertNotSame($hashWithout, $fileHashComputer->compute($configFilePath));
+    }
+}

tests/Bootstrap/config/some_config.php

@@ -0,0 +1,8 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+};