[Arguments] Fix ReplaceArgumentDefaultValueRector re-applying already-migrated imported class constant (#8475)

Author: TomasVotruba

rules-tests/Arguments/Rector/ClassMethod/ReplaceArgumentDefaultValueRector/Fixture/skip_imported_class_const_already_replaced.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Arguments\Rector\ClassMethod\ReplaceArgumentDefaultValueRector\Fixture;
+
+use Rector\Tests\Arguments\Rector\ClassMethod\ReplaceArgumentDefaultValueRector\Source\SomeSortableObject;
+
+class SkipImportedClassConstAlreadyReplaced
+{
+    public function run()
+    {
+        $object = new SomeSortableObject();
+        $object->sortBy(SomeSortableObject::SORT_ORDER_DESC);
+    }
+}

rules-tests/Arguments/Rector/ClassMethod/ReplaceArgumentDefaultValueRector/config/configured_rule.php

@@ -94,5 +94,13 @@
                 'ASC',
                 'self::SORT_ORDER_DESC'
             ),
+
+            new ReplaceArgumentDefaultValue(
+                SomeSortableObject::class,
+                'sortBy',
+                0,
+                'DESC',
+                SomeSortableObject::class . '::SORT_ORDER_DESC'
+            ),
         ]);
 };

rules/Arguments/ArgumentDefaultValueReplacer.php

@@ -165,7 +165,6 @@ private function processArgs(
             $normalizedValueAfter = $this->normalizeValue($replaceArgumentDefaultValue->getValueAfter());
             if ($particularArg->value instanceof ClassConstFetch
                 && $particularArg->value->class instanceof Name
-                && $particularArg->value->class->isSpecialClassName()
                 && $normalizedValueAfter instanceof ClassConstFetch
                 && is_string($replaceArgumentDefaultValue->getValueAfter())
                 && str_contains($replaceArgumentDefaultValue->getValueAfter(), '::')) {

rules/Arguments/Rector/ClassMethod/ReplaceArgumentDefaultValueRector.php

@@ -105,7 +105,7 @@ public function refactor(Node $node): MethodCall|StaticCall|ClassMethod|New_|nul
                 $currentNode,
                 $replaceArgumentDefaultValue
             );
-            if ($replacedNode !== null && $replacedNode !== $currentNode) {
+            if ($replacedNode !== null) {
                 $currentNode = $replacedNode;
                 $hasChanged = true;
             }
@@ -142,7 +142,7 @@ private function refactorNew(New_ $new): ?New_
                 $currentNode,
                 $replaceArgumentDefaultValue
             );
-            if ($replacedNode !== null && $replacedNode !== $currentNode) {
+            if ($replacedNode !== null) {
                 $currentNode = $replacedNode;
                 $hasChanged = true;
             }