Repository navigation
Commit 7f1e48a
committed
[dx] Deprecate CombineIfRector
Merging nested ifs can create much less readable code and depends on context. Replace the body with a deprecation message, remove its tests, and unregister it from the if set. Skip the type-perfect narrowing of the generic CommentsMerger::keepComments(), which only appears because this rule stopped calling it.
Claude-Session: https://claude.ai/code/session_012HQ19gVsT8wVkekuVqVXGx1 parent 5df5391 commit 7f1e48a
17 files changed
Lines changed: 13 additions & 458 deletions
File tree
- config/set
- rules-tests/CodeQuality/Rector/If_/CombineIfRector
- Fixture
- config
- rules/CodeQuality/Rector/If_
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
12 | 11 | | |
13 | | - | |
14 | 12 | | |
15 | 13 | | |
16 | 14 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
68 | 73 | | |
69 | 74 | | |
70 | 75 | | |
| |||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
0 commit comments