[CodeQuality] Deprecate SimplifyStrposLowerRector as niche rule, not part of PHP upgrade path

Author: TomasVotruba

rules-tests/CodeQuality/Rector/FuncCall/SimplifyStrposLowerRector/Fixture/skip_dynamic_second_arg.php.inc

@@ -4,25 +4,19 @@
 
 namespace Rector\CodeQuality\Rector\FuncCall;
 
-use Nette\Utils\Strings;
 use PhpParser\Node;
 use PhpParser\Node\Expr\FuncCall;
-use PhpParser\Node\Name;
-use PhpParser\Node\Scalar\String_;
+use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
+use Rector\Exception\ShouldNotHappenException;
 use Rector\Rector\AbstractRector;
 use Rector\RuleDoc\CodeSample\CodeSample;
 use Rector\RuleDoc\RuleDefinition;
 
 /**
- * @see \Rector\Tests\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector\SimplifyStrposLowerRectorTest
+ * @deprecated This rule is deprecated, as it handles a niche strpos(strtolower()) case that is not part of the PHP upgrade path.
  */
-final class SimplifyStrposLowerRector extends AbstractRector
+final class SimplifyStrposLowerRector extends AbstractRector implements DeprecatedInterface
 {
-    /**
-     * @see https://regex101.com/r/Jokjt8/1
-     */
-    private const string UPPERCASE_REGEX = '#[A-Z]#';
-
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
@@ -44,42 +38,9 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
-        if (! $this->isName($node, 'strpos')) {
-            return null;
-        }
-
-        if ($node->isFirstClassCallable()) {
-            return null;
-        }
-
-        $args = $node->getArgs();
-        if (! isset($args[0], $args[1])) {
-            return null;
-        }
-
-        $firstArg = $args[0];
-        if (! $firstArg->value instanceof FuncCall) {
-            return null;
-        }
-
-        $innerFuncCall = $firstArg->value;
-        if (! $this->isName($innerFuncCall, 'strtolower')) {
-            return null;
-        }
-
-        $secondArg = $args[1];
-        if (! $secondArg->value instanceof String_) {
-            return null;
-        }
-
-        if (Strings::match($secondArg->value->value, self::UPPERCASE_REGEX) !== null) {
-            return null;
-        }
-
-        // pop 1 level up
-        $node->args[0] = $innerFuncCall->getArgs()[0];
-        $node->name = new Name('stripos');
-
-        return $node;
+        throw new ShouldNotHappenException(sprintf(
+            '"%s" rule is deprecated, as it handles a niche strpos(strtolower()) case that is not part of the PHP upgrade path',
+            self::class
+        ));
     }
 }

rules-tests/CodeQuality/Rector/FuncCall/SimplifyStrposLowerRector/Fixture/skip_has_uppercase_second_arg.php.inc

@@ -43,7 +43,6 @@
 use Rector\CodeQuality\Rector\FuncCall\SetTypeToCastRector;
 use Rector\CodeQuality\Rector\FuncCall\SimplifyFuncGetArgsCountRector;
 use Rector\CodeQuality\Rector\FuncCall\SimplifyInArrayValuesRector;
-use Rector\CodeQuality\Rector\FuncCall\SimplifyStrposLowerRector;
 use Rector\CodeQuality\Rector\FuncCall\SingleInArrayToCompareRector;
 use Rector\CodeQuality\Rector\FuncCall\SortCallLikeNamedArgsRector;
 use Rector\CodeQuality\Rector\Identical\BooleanNotIdenticalToNotIdenticalRector;
@@ -120,7 +119,6 @@ final class CodeQualityLevel
         SimplifyForeachToCoalescingRector::class,
         SimplifyFuncGetArgsCountRector::class,
         SimplifyInArrayValuesRector::class,
-        SimplifyStrposLowerRector::class,
         SimplifyArraySearchRector::class,
         SimplifyConditionsRector::class,
         SimplifyIfNotNullReturnRector::class,