Fix scope on enum on combine DowngradeEnumToConstantListClassRector + RenameMethodRector (#8727)

* Fix scope on enum on combine DowngradeEnumToConstantListClassRector + RenameMethodRector

* Fix scope on enum on combine DowngradeEnumToConstantListClassRector + RenameMethodRector

Author: samsonasik

src/Application/ChangedNodeScopeRefresher.php

@@ -36,6 +36,7 @@
 use PHPStan\Analyser\MutatingScope;
 use Rector\Exception\ShouldNotHappenException;
 use Rector\NodeAnalyzer\ScopeAnalyzer;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\NodeTypeResolver\PHPStan\Scope\PHPStanNodeScopeResolver;
 use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 
@@ -80,6 +81,8 @@ public function refresh(Node $node, string $filePath, ?MutatingScope $mutatingSc
         // a class-like scope is already inside the class, so PHPStan cannot enter it again and would fail
         // on the class node, leaving its methods with the class scope; process the class stmts directly instead
         if ($node instanceof ClassLike && $mutatingScope->isInClass()) {
+            // the class node itself is not part of its stmts, e.g. an Enum_ replaced by a new Class_ has no scope yet
+            $node->setAttribute(AttributeKey::SCOPE, $mutatingScope);
             $this->phpStanNodeScopeResolver->processNodes($node->stmts, $filePath, $mutatingScope);
             return;
         }

tests/Issues/EnumToClassScopeRefresh/EnumToClassScopeRefreshTest.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Issues\EnumToClassScopeRefresh;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class EnumToClassScopeRefreshTest extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/configured_rule.php';
+    }
+}

tests/Issues/EnumToClassScopeRefresh/Fixture/scope_on_class_from_enum.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\Issues\EnumToClassScopeRefresh\Fixture;
+
+enum ScopeOnClassFromEnum
+{
+    case Char;
+    case Word;
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Issues\EnumToClassScopeRefresh\Fixture;
+
+class ScopeOnClassFromEnum
+{
+    public const Char = 'char';
+    public const Word = 'word';
+}
+
+?>

tests/Issues/EnumToClassScopeRefresh/config/configured_rule.php

@@ -0,0 +1,14 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DowngradePhp80\Rector\Enum_\DowngradeEnumToConstantListClassRector;
+use Rector\Renaming\Rector\MethodCall\RenameMethodRector;
+use Rector\Renaming\ValueObject\MethodCallRename;
+
+return RectorConfig::configure()
+    ->withRules([DowngradeEnumToConstantListClassRector::class])
+    ->withConfiguredRule(RenameMethodRector::class, [
+        new MethodCallRename('SomeClass', 'oldMethod', 'newMethod'),
+    ]);