[AutoImport] Avoid used import into param that skipped from removal rule (#8078)

* [AutoImport] Avoid used import into param that skipped from removal rule

* fix

* avoid repeated clone

* Revert "avoid repeated clone"

This reverts commit de88dba.

* handle set php doc info null on AbstractRector

* add visitor

Author: samsonasik

src/PhpParser/NodeVisitor/PhpDocInfoRemovingNodeVisitor.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PhpParser\NodeVisitor;
+
+use PhpParser\Node;
+use PhpParser\NodeVisitorAbstract;
+use Rector\NodeTypeResolver\Node\AttributeKey;
+
+final class PhpDocInfoRemovingNodeVisitor extends NodeVisitorAbstract
+{
+    public function enterNode(Node $node): Node
+    {
+        $node->setAttribute(AttributeKey::PHP_DOC_INFO, null);
+        return $node;
+    }
+}

src/Rector/AbstractRector.php

@@ -35,6 +35,7 @@
 use Rector\PhpDocParser\NodeTraverser\SimpleCallableNodeTraverser;
 use Rector\PhpParser\Comparing\NodeComparator;
 use Rector\PhpParser\Node\NodeFactory;
+use Rector\PhpParser\NodeVisitor\PhpDocInfoRemovingNodeVisitor;
 use Rector\Skipper\Skipper\Skipper;
 use Rector\Skipper\ValueObject\SkipMatch;
 use Rector\ValueObject\Application\File;
@@ -280,7 +281,7 @@ protected function mirrorComments(Node $newNode, Node $oldNode): void
      */
     private function cloneNode(Node $node): Node
     {
-        $nodeTraverser = new NodeTraverser(new CloningVisitor());
+        $nodeTraverser = new NodeTraverser(new CloningVisitor(), new PhpDocInfoRemovingNodeVisitor());
         return $nodeTraverser->traverse([$node])[0];
     }
 

stubs/Config/App.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Config;
+
+if (class_exists('Config\App')) {
+    return;
+}
+
+class App
+{
+}

tests/Issues/ImportFullyQualifiedIdentifierDocblock/Fixture/keep_import_used_in_param.php.inc

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+namespace CodeIgniter\HTTP;
+
+use Config\App;
+
+final class Response
+{
+    public $property;
+
+    /**
+     * @param App $config
+     *
+     * @deprecated The param $config is no longer used.
+     */
+    public function __construct($config)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace CodeIgniter\HTTP;
+
+use DateTime;
+use Config\App;
+
+final class Response
+{
+    /**
+     * @var DateTime
+     */
+    public $property;
+
+    /**
+     * @param App $config
+     *
+     * @deprecated The param $config is no longer used.
+     */
+    public function __construct($config)
+    {
+    }
+}
+
+?>

tests/Issues/ImportFullyQualifiedIdentifierDocblock/config/configured_rule.php

@@ -3,8 +3,14 @@
 declare(strict_types=1);
 
 use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector;
 use Rector\Tests\Issues\ImportFullyQualifiedIdentifierDocblock\Source\AddFullyQualifiedIdentifierDocblockRector;
 
 return RectorConfig::configure()
-    ->withRules([AddFullyQualifiedIdentifierDocblockRector::class])
-    ->withImportNames();
+    ->withRules([AddFullyQualifiedIdentifierDocblockRector::class, RemoveUnusedConstructorParamRector::class])
+    ->withImportNames()
+    ->withSkip([
+        RemoveUnusedConstructorParamRector::class => [
+            realpath(__DIR__ . '/../Fixture') . '/keep_import_used_in_param.php',
+        ],
+    ]);