Skip to content

Commit b7c1cd5

Browse files
authored
Remove stale PHPStan ignores (#8566)
* Report unmatched PHPStan ignores and remove the stale ones * Keep reportUnmatchedIgnoredErrors disabled for now
1 parent e0dc680 commit b7c1cd5

1 file changed

Lines changed: 0 additions & 45 deletions

File tree

‎phpstan.neon‎

Lines changed: 0 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,6 @@ parameters:
6565
constants: true
6666

6767
ignoreErrors:
68-
# keepComments() is a generic helper; do not narrow it after the deprecated CombineIfRector stopped calling it
69-
-
70-
identifier: typePerfect.narrowPublicClassMethodParamType
71-
path: src/BetterPhpDocParser/Comment/CommentsMerger.php
72-
7368
# the deprecated set objects are still resolved internally, until every extension bonds its rules
7469
-
7570
message: '#deprecated (class|interface) Rector\\(Set|Bridge)\\#'
@@ -125,11 +120,6 @@ parameters:
125120
message: '#Parameter \#1 \$items of class PhpParser\\Node\\Expr\\Array_ constructor expects array<PhpParser\\Node\\ArrayItem>, array<PhpParser\\Node\\ArrayItem\|null> given#'
126121
path: rules/Php71/Rector/List_/ListToArrayDestructRector.php
127122

128-
-
129-
identifier: argument.type
130-
message: '#Parameter \#3 \$assign of method Rector\\CodeQuality\\Rector\\FunctionLike\\SimplifyUselessVariableRector\:\:processSimplifyUselessVariable\(\) expects PhpParser\\Node\\Expr\\Assign\|PhpParser\\Node\\Expr\\AssignOp, PhpParser\\Node\\Expr given#'
131-
path: rules/CodeQuality/Rector/FunctionLike/SimplifyUselessVariableRector.php
132-
133123
# scope vs mutating scope
134124
-
135125
identifier: argument.type
@@ -148,10 +138,6 @@ parameters:
148138
- rules/TypeDeclarationDocblocks/Rector/Class_/AddVarArrayDocblockFromDimFetchAssignRector.php
149139
- src/NodeTypeResolver/PHPStan/Type/TypeFactory.php
150140

151-
-
152-
identifier: arguments.count
153-
message: '#Callable callable\(PHPStan\\Type\\Type\)\: PHPStan\\Type\\Type invoked with 2 parameters, 1 required#'
154-
155141
# classes are part of *.php.inc fixture
156142
-
157143
identifier: class.notFound
@@ -345,32 +331,6 @@ parameters:
345331
paths:
346332
- src/Skipper/SkipCriteriaResolver/SkippedClassResolver.php
347333

348-
# native filesystem calls, required for performance reasons
349-
-
350-
identifier: symplify.forbiddenNode
351-
message: '#@(.*?) is forbidden to use#'
352-
path: src/Caching/ValueObject/Storage/FileCacheStorage.php
353-
354-
-
355-
identifier: symplify.forbiddenNode
356-
message: '#@\\ini_set\(.*\)" is forbidden to use#'
357-
path: bin/rector.php
358-
359-
-
360-
message: '#PHPDoc tag @var with type array<string> is not subtype of native type array#'
361-
path: src/Bootstrap/ExtensionConfigResolver.php
362-
363-
-
364-
identifier: symplify.forbiddenStaticClassConstFetch
365-
message: '#Avoid static access of constants, as they can change value\. Use interface and contract method instead#'
366-
paths:
367-
- src/PostRector/Rector/AbstractPostRector.php
368-
- src/Testing/PHPUnit/AbstractRectorTestCase.php
369-
370-
-
371-
identifier: symplify.forbiddenStaticClassConstFetch
372-
path: src/Rector/AbstractRector.php
373-
374334
-
375335
identifier: symplify.noConstructorOverride
376336
path: src/StaticTypeMapper/ValueObject/Type/SimpleStaticType.php
@@ -413,11 +373,6 @@ parameters:
413373
path: src/PhpParser/Parser/RectorParser.php
414374

415375
# known types
416-
-
417-
identifier: varTag.nativeType
418-
message: '#PHPDoc tag @var with type array<string, int> is not subtype of native type array<int<1, max>>#'
419-
path: rules/Naming/PhpArray/ArrayFilter.php
420-
421376
-
422377
identifier: varTag.nativeType
423378
path: src/BetterPhpDocParser/PhpDocParser/StaticDoctrineAnnotationParser.php

0 commit comments

Comments
 (0)