[Php80] Skip empty string needle in StrContainsRector (#8460)

Author: TomasVotruba

rules-tests/Php80/Rector/NotIdentical/StrContainsRector/Fixture/skip_empty_needle_strpos.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\NotIdentical\StrContainsRector\Fixture;
+
+class SkipEmptyNeedleStrpos
+{
+    public function run()
+    {
+        return strpos('abc', '') !== false;
+    }
+}

rules-tests/Php80/Rector/NotIdentical/StrContainsRector/Fixture/skip_empty_needle_strstr.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\NotIdentical\StrContainsRector\Fixture;
+
+class SkipEmptyNeedleStrstr
+{
+    public function run()
+    {
+        return strstr('abc', '') !== false;
+    }
+}

rules/Php80/Rector/NotIdentical/StrContainsRector.php

@@ -15,6 +15,7 @@
 use PhpParser\Node\Expr\FuncCall;
 use PhpParser\Node\Name;
 use PhpParser\Node\Scalar\Int_;
+use PhpParser\Node\Scalar\String_;
 use Rector\Php80\NodeResolver\StrFalseComparisonResolver;
 use Rector\Rector\AbstractRector;
 use Rector\ValueObject\PhpVersionFeature;
@@ -97,6 +98,11 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        $args = $funcCall->getArgs();
+        if (isset($args[1]) && $this->isEmptyStringNeedle($args[1]->value)) {
+            return null;
+        }
+
         if (isset($funcCall->getArgs()[2])) {
             $secondArg = $funcCall->getArgs()[2];
 
@@ -132,4 +138,13 @@ private function isIntegerZero(Expr $expr): bool
 
         return $expr->value === 0;
     }
+
+    private function isEmptyStringNeedle(Expr $expr): bool
+    {
+        if (! $expr instanceof String_) {
+            return false;
+        }
+
+        return $expr->value === '';
+    }
 }