Skip to content

Commit be11cb4

Browse files
committed
add note on self-extends skip
1 parent 328156a commit be11cb4

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎rules/Renaming/NodeManipulator/ClassRenamer.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ private function refactorClassLike(ClassLike $classLike, array $oldToNewClasses,
189189
$extendsName = $classLike->extends->toString();
190190
$newName = $oldToNewClasses[$extendsName] ?? null;
191191

192-
// skip when the class would extend itself after rename
192+
// skip when the class would extend itself after rename; this might happen when you run a rename class on new child class that extends the deprecated one
193193
if ($newName !== null
194194
&& $newName !== $this->nodeNameResolver->getName($classLike)
195195
&& $this->isClassToInterfaceValidChange($classLike->extends, $newName)

0 commit comments

Comments
 (0)