[CodeQuality] Move RemoveAlwaysElseRector, PreparedValueToEarlyReturnRector and ReturnEarlyIfVariableRector to code quality set

These rules improve local code quality rather than enforce the early-return
style. Move their set registration from early-return to CodeQualityLevel.
The rule classes stay in their current namespace.

Author: TomasVotruba

config/set/early-return.php

@@ -6,19 +6,13 @@
 use Rector\EarlyReturn\Rector\Foreach_\ChangeNestedForeachIfsToEarlyContinueRector;
 use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
 use Rector\EarlyReturn\Rector\If_\ChangeNestedIfsToEarlyReturnRector;
-use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
-use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
 use Rector\EarlyReturn\Rector\Return_\ReturnBinaryOrToEarlyReturnRector;
-use Rector\EarlyReturn\Rector\StmtsAwareInterface\ReturnEarlyIfVariableRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->rules([
         ChangeNestedForeachIfsToEarlyContinueRector::class,
         ChangeIfElseValueAssignToEarlyReturnRector::class,
         ChangeNestedIfsToEarlyReturnRector::class,
-        RemoveAlwaysElseRector::class,
-        PreparedValueToEarlyReturnRector::class,
         ReturnBinaryOrToEarlyReturnRector::class,
-        ReturnEarlyIfVariableRector::class,
     ]);
 };

rules/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector.php

@@ -172,7 +172,7 @@ private function isPropertyDefinedInParentClass(Class_ $class, string $propertyN
             return true;
         }
 
-        return array_any($classReflection->getParents(), fn(ClassReflection $parentClassReflection) => $parentClassReflection->getNativeReflection()->hasProperty($propertyName));
+        return array_any($classReflection->getParents(), fn (ClassReflection $parentClassReflection) => $parentClassReflection->getNativeReflection()->hasProperty($propertyName));
     }
 
     private function matchAssignedLocalPropertyName(Assign $assign): ?string

src/Config/Level/CodeQualityLevel.php

@@ -72,6 +72,9 @@
 use Rector\CodeQuality\Rector\Ternary\UnnecessaryTernaryExpressionRector;
 use Rector\CodingStyle\Rector\Ternary\TernaryConditionVariableAssignmentRector;
 use Rector\Contract\Rector\RectorInterface;
+use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
+use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
+use Rector\EarlyReturn\Rector\StmtsAwareInterface\ReturnEarlyIfVariableRector;
 use Rector\Php52\Rector\Property\VarToPublicPropertyRector;
 use Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector;
 use Rector\Renaming\Rector\FuncCall\RenameFunctionRector;
@@ -154,6 +157,9 @@ final class CodeQualityLevel
         CallUserFuncWithArrowFunctionToInlineRector::class,
         FlipTypeControlToUseExclusiveTypeRector::class,
         InlineArrayReturnAssignRector::class,
+        RemoveAlwaysElseRector::class,
+        PreparedValueToEarlyReturnRector::class,
+        ReturnEarlyIfVariableRector::class,
         InlineIsAInstanceOfRector::class,
         InlineConstructorDefaultToPropertyRector::class,
         TernaryEmptyArrayArrayDimFetchToCoalesceRector::class,