[TypeDeclaration] Skip trait methods on ParamTypeByMethodCallType rules (#8189)

Author: TomasVotruba

rules-tests/TypeDeclaration/Rector/ClassMethod/ArrayParamTypeByMethodCallTypeRector/Fixture/skip_trait.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ArrayParamTypeByMethodCallTypeRector\Fixture;
+
+trait SkipTrait
+{
+    public function go($value)
+    {
+        $this->use($value);
+    }
+
+    private function use(array $value): void
+    {
+    }
+}

rules/TypeDeclaration/Rector/ClassMethod/AbstractParamTypeByMethodCallTypeRector.php

@@ -13,6 +13,7 @@
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
+use PHPStan\Analyser\Scope;
 use PHPStan\Type\Type;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\NodeTypeResolver\PHPStan\Type\TypeFactory;
@@ -99,6 +100,12 @@ abstract protected function isMatchingParamType(Type $type): bool;
 
     private function shouldSkipClassMethod(ClassMethod $classMethod): bool
     {
+        // trait method can be used in a class that requires a contract type, adding a param type would break it
+        $scope = $classMethod->getAttribute(AttributeKey::SCOPE);
+        if ($scope instanceof Scope && $scope->isInTrait()) {
+            return true;
+        }
+
         // user-guarded class: adding a param type here would break its child classes
         if ($this->parentClassMethodTypeOverrideGuard->isTypeGuardedClass($classMethod)) {
             return true;