[DeadCode] Speed up RemoveAlwaysTrueIfConditionRector with single node traversal (#8653)

* [CodeQuality] Speed up ExplicitNullableObjectInstanceRector with cheap bail before native type resolution

* [DeadCode] Speed up RemoveAlwaysTrueIfConditionRector with single node traversal

Author: TomasVotruba

rules/CodeQuality/NodeAnalyzer/ExplicitBoolConditionResolver.php

@@ -5,8 +5,12 @@
 namespace Rector\CodeQuality\NodeAnalyzer;
 
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\BinaryOp;
 use PhpParser\Node\Expr\BooleanNot;
 use PhpParser\Node\Expr\Cast\Bool_;
+use PhpParser\Node\Expr\Empty_;
+use PhpParser\Node\Expr\Instanceof_;
+use PhpParser\Node\Expr\Isset_;
 use PhpParser\Node\Expr\Ternary;
 use PhpParser\Node\Stmt\ElseIf_;
 use PhpParser\Node\Stmt\If_;
@@ -40,11 +44,24 @@ public function resolve(If_|ElseIf_|Ternary $node): ?ExplicitBoolCondition
             return null;
         }
 
+        // cheap bail - these shapes can never be a nullable object, skip costly native type resolution
+        if ($this->isNeverNullableObject($conditionNode)) {
+            return null;
+        }
+
         $conditionStaticType = $this->nodeTypeResolver->getNativeType($conditionNode);
         if ($conditionStaticType instanceof MixedType || $conditionStaticType->isBoolean()->yes()) {
             return null;
         }
 
         return new ExplicitBoolCondition($conditionNode, $isNegated);
     }
+
+    private function isNeverNullableObject(Expr $expr): bool
+    {
+        return $expr instanceof BinaryOp
+            || $expr instanceof Instanceof_
+            || $expr instanceof Empty_
+            || $expr instanceof Isset_;
+    }
 }

rules/DeadCode/Rector/If_/RemoveAlwaysTrueIfConditionRector.php

@@ -197,30 +197,17 @@ private function shouldSkipFromVariable(Expr $expr, Scope $scope): bool
 
     private function shouldSkipExpr(Expr $expr): bool
     {
-        $hasNonStaticNode = (bool) $this->betterNodeFinder->findInstancesOf(
-            $expr,
-            [
-                PropertyFetch::class,
-                StaticPropertyFetch::class,
-                ArrayDimFetch::class,
-                MethodCall::class,
-                StaticCall::class,
-            ]
-        );
-
-        if ($hasNonStaticNode) {
-            return true;
-        }
-
-        /** @var FuncCall[] $funcCalls */
-        $funcCalls = $this->betterNodeFinder->findInstancesOf($expr, [FuncCall::class]);
-        foreach ($funcCalls as $funcCall) {
-            if ($this->isNames($funcCall, self::RUNTIME_STATE_FUNCTIONS)) {
+        return $this->betterNodeFinder->findFirst($expr, function (Node $node): bool {
+            if ($node instanceof PropertyFetch
+                || $node instanceof StaticPropertyFetch
+                || $node instanceof ArrayDimFetch
+                || $node instanceof MethodCall
+                || $node instanceof StaticCall) {
                 return true;
             }
-        }
 
-        return false;
+            return $node instanceof FuncCall && $this->isNames($node, self::RUNTIME_STATE_FUNCTIONS);
+        }) instanceof Node;
     }
 
     private function refactorIfWithBooleanAnd(If_ $if): ?If_