Skip to content

Commit d43a698

Browse files
authored
Remove DeprecatedAnnotationToDeprecatedAttributeRector from PHP 8.4 set (#8326)
1 parent c6fc794 commit d43a698

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

‎config/set/php84.php‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
declare(strict_types=1);
44

55
use Rector\Config\RectorConfig;
6-
use Rector\Php84\Rector\Class_\DeprecatedAnnotationToDeprecatedAttributeRector;
76
use Rector\Php84\Rector\Foreach_\ForeachToArrayAllRector;
87
use Rector\Php84\Rector\Foreach_\ForeachToArrayAnyRector;
98
use Rector\Php84\Rector\Foreach_\ForeachToArrayFindKeyRector;
@@ -19,7 +18,6 @@
1918
RoundingModeEnumRector::class,
2019
AddEscapeArgumentRector::class,
2120
NewMethodCallWithoutParenthesesRector::class,
22-
DeprecatedAnnotationToDeprecatedAttributeRector::class,
2321
ForeachToArrayFindRector::class,
2422
ForeachToArrayFindKeyRector::class,
2523
ForeachToArrayAllRector::class,

‎phpstan.neon‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,12 @@ parameters:
123123
identifier: rector.upgradeDowngradeRegisteredInSet
124124
path: rules/Php81/Rector/FuncCall/NullToStrictStringFuncCallArgRector.php
125125

126+
# deliberately kept out of the php84 set, as it turns a doc annotation into a runtime deprecation;
127+
# it stays available to register directly with withRules()
128+
-
129+
identifier: rector.upgradeDowngradeRegisteredInSet
130+
path: rules/Php84/Rector/Class_/DeprecatedAnnotationToDeprecatedAttributeRector.php
131+
126132
# is nested expr
127133
-
128134
message: '#Access to an undefined property PhpParser\\Node\\Expr\:\:\$expr#'

0 commit comments

Comments
 (0)