Skip to content

Commit d90e42d

Browse files
committed
[dx] Deprecate ExplicitBoolCompareRector
Array and object bool compares have dedicated rules; the remaining behavior is an opinionated approach that depends on context. Replace the body with a deprecation message, remove its tests, and unregister it from the if set. Claude-Session: https://claude.ai/code/session_012HQ19gVsT8wVkekuVqVXGx
1 parent 5df5391 commit d90e42d

20 files changed

Lines changed: 9 additions & 803 deletions

‎config/set/if.php‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,11 @@
33
declare(strict_types=1);
44

55
use Rector\CodeQuality\Rector\If_\CombineIfRector;
6-
use Rector\CodeQuality\Rector\If_\ExplicitBoolCompareRector;
76
use Rector\CodeQuality\Rector\If_\SimplifyIfElseToTernaryRector;
87
use Rector\Config\RectorConfig;
98

109
return static function (RectorConfig $rectorConfig): void {
1110
$rectorConfig->rules([
12-
ExplicitBoolCompareRector::class,
1311
CombineIfRector::class,
1412
SimplifyIfElseToTernaryRector::class,
1513
]);

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/ExplicitBoolCompareRectorTest.php‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/count.php.inc‎

Lines changed: 0 additions & 35 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/explode.php.inc‎

Lines changed: 0 additions & 37 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/if_assign_cond.php.inc‎

Lines changed: 0 additions & 36 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/numbers.php.inc‎

Lines changed: 0 additions & 53 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/phpstan_0_12_6break.php.inc‎

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/skip_if_else.php.inc‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/skip_nested_array_mixed.php.inc‎

Lines changed: 0 additions & 17 deletions
This file was deleted.

‎rules-tests/CodeQuality/Rector/If_/ExplicitBoolCompareRector/Fixture/skip_phpdoc-typed.php.inc‎

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)