Repository navigation
Commit d9c5826
committed
[BetterPhpDocParser] inject phpdoc node decorators explicitly to keep required order
Autodiscovering the decorators used filesystem order, dropping
DoctrineAnnotationDecorator to last. It must run before
ArrayItemClassNameDecorator, which resolves class names in the
ArrayItemNodes it produces (e.g. @Orm\Column(type=Types::STRING)).
Wrong order silently lost annotation class usages and removed their
imports via removeUnusedImports().
Inject the four decorators as explicit constructor params, in order,
with a comment explaining the constraint.1 parent f4cd9bb commit d9c5826
2 files changed
Lines changed: 25 additions & 24 deletions
File tree
- src
- BetterPhpDocParser/PhpDocParser
- DependencyInjection
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
| |||
44 | 48 | | |
45 | 49 | | |
46 | 50 | | |
47 | | - | |
| 51 | + | |
48 | 52 | | |
| 53 | + | |
| 54 | + | |
49 | 55 | | |
50 | 56 | | |
51 | 57 | | |
52 | 58 | | |
53 | 59 | | |
54 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
55 | 64 | | |
56 | 65 | | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
57 | 80 | | |
58 | 81 | | |
59 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | 22 | | |
28 | 23 | | |
29 | 24 | | |
| |||
119 | 114 | | |
120 | 115 | | |
121 | 116 | | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | 117 | | |
133 | 118 | | |
134 | 119 | | |
| |||
287 | 272 | | |
288 | 273 | | |
289 | 274 | | |
290 | | - | |
291 | | - | |
292 | | - | |
293 | | - | |
294 | | - | |
295 | | - | |
296 | | - | |
297 | 275 | | |
298 | 276 | | |
299 | 277 | | |
| |||
0 commit comments