Skip to content

Commit dc32e6e

Browse files
committed
[PHP 8.3] Remove docblock if useless in AddTypeToConstRector to avoid duplicated leftovers"
1 parent a8bb550 commit dc32e6e

2 files changed

Lines changed: 37 additions & 1 deletion

File tree

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
<?php
2+
3+
namespace Rector\Tests\Php83\Rector\ClassConst\AddTypeToConstRector\Fixture;
4+
5+
final class RemoveDocBlockAsUseless
6+
{
7+
/**
8+
* @var int
9+
*/
10+
private const A = 1000;
11+
}
12+
13+
?>
14+
-----
15+
<?php
16+
17+
namespace Rector\Tests\Php83\Rector\ClassConst\AddTypeToConstRector\Fixture;
18+
19+
final class RemoveDocBlockAsUseless
20+
{
21+
private const int A = 1000;
22+
}
23+
24+
?>

‎rules/Php83/Rector/ClassConst/AddTypeToConstRector.php‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,16 @@
2121
use PhpParser\Node\Stmt\ClassConst;
2222
use PHPStan\Reflection\ClassReflection;
2323
use PHPStan\Reflection\ReflectionProvider;
24+
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfo;
25+
use Rector\BetterPhpDocParser\PhpDocInfo\PhpDocInfoFactory;
2426
use Rector\Configuration\Parameter\FeatureFlags;
27+
use Rector\DeadCode\PhpDoc\TagRemover\VarTagRemover;
2528
use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
2629
use Rector\Rector\AbstractRector;
2730
use Rector\StaticTypeMapper\StaticTypeMapper;
2831
use Rector\ValueObject\PhpVersionFeature;
2932
use Rector\VersionBonding\Contract\MinPhpVersionInterface;
33+
use Symplify\CodingStandard\DocBlock\UselessDocBlockCleaner;
3034
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
3135
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
3236

@@ -37,7 +41,9 @@ final class AddTypeToConstRector extends AbstractRector implements MinPhpVersion
3741
{
3842
public function __construct(
3943
private readonly ReflectionProvider $reflectionProvider,
40-
private readonly StaticTypeMapper $staticTypeMapper
44+
private readonly StaticTypeMapper $staticTypeMapper,
45+
private readonly VarTagRemover $varTagRemover,
46+
private readonly PhpDocInfoFactory $phpDocInfoFactory,
4147
) {
4248
}
4349

@@ -130,6 +136,12 @@ public function refactor(Node $node): ?Class_
130136

131137
$classConst->type = $valueType;
132138
$hasChanged = true;
139+
140+
$classConstPhpDocInfo = $this->phpDocInfoFactory->createFromNode($classConst);
141+
142+
if ($classConstPhpDocInfo instanceof PhpDocInfo) {
143+
$this->varTagRemover->removeVarTagIfUseless($classConstPhpDocInfo, $classConst);
144+
}
133145
}
134146

135147
if (! $hasChanged) {

0 commit comments

Comments
 (0)