perf: reject non-callable arrays before scope lookup (#8796)

Author: alfredbez

rules-tests/Php81/Rector/Array_/ArrayToFirstClassCallableRector/ArrayToFirstClassCallableRectorTest.php

@@ -5,7 +5,13 @@
 namespace Rector\Tests\Php81\Rector\Array_\ArrayToFirstClassCallableRector;
 
 use Iterator;
+use PhpParser\Node\ArrayItem;
+use PhpParser\Node\Expr\Array_;
+use PhpParser\Node\Expr\Variable;
+use PhpParser\Node\Scalar\String_;
 use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\Php81\Rector\Array_\ArrayToFirstClassCallableRector;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 
 final class ArrayToFirstClassCallableRectorTest extends AbstractRectorTestCase
@@ -21,6 +27,39 @@ public static function provideData(): Iterator
         return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
     }
 
+    #[DataProvider('provideSkippedArrays')]
+    public function testSkipWithoutScope(Array_ $array): void
+    {
+        $rector = $this->make(ArrayToFirstClassCallableRector::class);
+
+        $this->assertNull($rector->refactor($array));
+    }
+
+    /**
+     * @return Iterator<string, array{Array_}>
+     */
+    public static function provideSkippedArrays(): Iterator
+    {
+        $caller = new ArrayItem(new Variable('this'));
+        $method = new ArrayItem(new String_('run'));
+
+        yield 'empty array' => [new Array_()];
+        yield 'one item' => [new Array_([$caller])];
+        yield 'three items' => [new Array_([$caller, $method, $method])];
+
+        foreach ([
+            AttributeKey::IS_CLASS_CONST_VALUE,
+            AttributeKey::IS_DEFAULT_PROPERTY_VALUE,
+            AttributeKey::IS_PARAM_DEFAULT,
+            AttributeKey::IS_UNPACKED_ARG_VALUE,
+        ] as $attribute) {
+            yield $attribute => [
+                new Array_([$caller, $method], [
+                    $attribute => true,
+                ])];
+        }
+    }
+
     public function provideConfigFilePath(): string
     {
         return __DIR__ . '/config/configured_rule.php';

rules/Php81/Rector/Array_/ArrayToFirstClassCallableRector.php

@@ -5,6 +5,7 @@
 namespace Rector\Php81\Rector\Array_;
 
 use PhpParser\Node;
+use PhpParser\Node\ArrayItem;
 use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\ClassConstFetch;
 use PhpParser\Node\Expr\MethodCall;
@@ -90,6 +91,14 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): StaticCall|MethodCall|null
     {
+        if (count($node->items) !== 2) {
+            return null;
+        }
+
+        if (! $node->items[0] instanceof ArrayItem || ! $node->items[1] instanceof ArrayItem) {
+            return null;
+        }
+
         if ($node->getAttribute(AttributeKey::IS_ARG_NOT_ACCEPTING_CLOSURE)) {
             return null;
         }