Skip constructor defaults on extensible classes

Author: Junaid-PK

rules-tests/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector/Fixture/skip_non_final_class.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+class ValidatedBase
+{
+    private bool $validated = false;
+
+    protected function __construct()
+    {
+        $this->validate();
+        $this->validated = true;
+    }
+
+    private function validate(): void
+    {
+    }
+}
+
+final class SkipsParentConstructor extends ValidatedBase
+{
+    public function __construct()
+    {
+    }
+}

rules/CodeQuality/Rector/Class_/InlineConstructorDefaultToPropertyRector.php

@@ -78,6 +78,11 @@ public function getNodeTypes(): array
      */
     public function refactor(Node $node): ?Node
     {
+        // A child class may bypass the constructor and depend on the declared property default
+        if (! $node->isFinal()) {
+            return null;
+        }
+
         $hasChanged = false;
 
         $constructClassMethod = $node->getMethod(MethodName::CONSTRUCT);