[dx] enable removing of unused imports, as well tested and often enabled manually (#8047)

* [dx] enable removing of unused imports, as well tested and often enabled manually

* add RemoveRefactorDuplicatedNodeInstanceCheckRector to rector pre-set

* [config] add AddSeeTestAnnotationRector to rector-preset

* update test fixtures

* [ci-review] Rector Rectify

---------

Co-authored-by: GitHub Action <actions@github.com>

Author: TomasVotruba

config/set/rector-preset.php

@@ -2,6 +2,8 @@
 
 declare(strict_types=1);
 
+use Rector\Utils\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector;
+use Rector\PHPUnit\CodeQuality\Rector\Class_\AddSeeTestAnnotationRector;
 use Rector\CodingStyle\Rector\PostInc\PostIncDecToPreIncDecRector;
 use Rector\Config\RectorConfig;
 use Rector\Privatization\Rector\Class_\FinalizeTestCaseClassRector;
@@ -12,5 +14,7 @@
         DeclareStrictTypesRector::class,
         PostIncDecToPreIncDecRector::class,
         FinalizeTestCaseClassRector::class,
+        RemoveRefactorDuplicatedNodeInstanceCheckRector::class,
+        AddSeeTestAnnotationRector::class,
     ]);
 };

rector.php

@@ -7,8 +7,6 @@
 use Rector\DeadCode\Rector\ClassMethod\RemoveUnusedPublicMethodParameterRector;
 use Rector\DeadCode\Rector\ConstFetch\RemovePhpVersionIdCheckRector;
 use Rector\Php55\Rector\String_\StringClassNameToClassConstantRector;
-use Rector\PHPUnit\CodeQuality\Rector\Class_\AddSeeTestAnnotationRector;
-use Rector\Utils\Rector\RemoveRefactorDuplicatedNodeInstanceCheckRector;
 
 return RectorConfig::configure()
     ->withPreparedSets(
@@ -39,8 +37,7 @@
         __DIR__ . '/build/build-preload.php',
     ])
     ->withRootFiles()
-    ->withImportNames(removeUnusedImports: true)
-    ->withRules([RemoveRefactorDuplicatedNodeInstanceCheckRector::class, AddSeeTestAnnotationRector::class])
+    ->withImportNames()
     ->withSkip([
         StringClassNameToClassConstantRector::class,
         // tests

src/Configuration/RectorConfigBuilder.php

@@ -950,7 +950,7 @@ public function withImportNames(
         bool $importNames = true,
         bool $importDocBlockNames = true,
         bool $importShortClasses = true,
-        bool $removeUnusedImports = false
+        bool $removeUnusedImports = true
     ): self {
         $this->importNames = $importNames;
         $this->importDocBlockNames = $importDocBlockNames;

tests/Issues/AnnotationToAttributeFirstClassCallable/Fixture/change_annotation_to_attribute.php.inc

@@ -42,4 +42,4 @@ namespace Symfony\Component\Serializer\Annotation
 
 }
 
-?>
+?>

tests/Issues/ImportFullyQualifiedIdentifierDocblock/Fixture/add_property_var2.php.inc

@@ -20,7 +20,6 @@ declare(strict_types=1);
 namespace Rector\Tests\Issues\ImportFullyQualifiedIdentifierDocblock;
 
 use DateTime;
-use stdClass;
 
 final class AddPropertyVar2
 {

tests/Issues/NamespacedUseAutoImport/Fixture/in_use_fqcn_docblock.php.inc

@@ -46,4 +46,4 @@ class InUseFqcnDocblock
     }
 }
 
-?>
+?>

tests/Issues/PrintStringNowDocUnderAttributeTarget/Fixture/fixture.php.inc

@@ -48,4 +48,4 @@ final readonly class Fixture
     ) {}
 }
 
-?>
+?>

tests/Issues/ScopeNotAvailable/FixtureForeachToArrayParam/fixture.php.inc

@@ -52,4 +52,4 @@ class Fixture
     }
 }
 
-?>
+?>