remove deprecated withPhp53Sets() ... withPhp74Sets() methods

Author: TomasVotruba

src/Configuration/Option.php

@@ -240,11 +240,6 @@ final class Option
      */
     public const string SKIPPED_NON_RECTOR_CLASSES = 'skipped_non_rector_classes';
 
-    /**
-     * @internal For reporting deprecated withPhp53Sets() ... withPhp74Sets() methods
-     */
-    public const string DEPRECATED_PHP_SETS_METHODS = 'deprecated_php_sets_methods';
-
     /**
      * @internal For reporting deprecated withAttributesSets() arguments
      */

src/Configuration/Parameter/SimpleParameterProvider.php

@@ -40,7 +40,6 @@ final class SimpleParameterProvider
         Option::SKIPPED_RECTOR_RULES,
         Option::SKIPPED_NON_RECTOR_CLASSES,
         Option::SKIPPED_START_WITH_SHORT_OPEN_TAG_FILES,
-        Option::DEPRECATED_PHP_SETS_METHODS,
         Option::DEPRECATED_ATTRIBUTES_SETS_ARGS,
         Option::DEPRECATED_COMPOSER_BASED_ARGS,
         Option::LEVEL_OVERFLOWS,

src/Configuration/RectorConfigBuilder.php

@@ -583,60 +583,6 @@ public function withPhpSets(
         return $this->addPhpLevelSets($pickedPhpVersions[0]);
     }
 
-    #[Deprecated(message: 'Use "withPhpLevel()" instead, it raises PHP level one rule at a time.')]
-    public function withPhp53Sets(): self
-    {
-        return $this->reportDeprecatedPhpSetsMethod(__FUNCTION__);
-    }
-
-    #[Deprecated(message: 'Use "withPhpLevel()" instead, it raises PHP level one rule at a time.')]
-    public function withPhp54Sets(): self
-    {
-        return $this->reportDeprecatedPhpSetsMethod(__FUNCTION__);
-    }
-
-    #[Deprecated(message: 'Use "withPhpLevel()" instead, it raises PHP level one rule at a time.')]
-    public function withPhp55Sets(): self
-    {
-        return $this->reportDeprecatedPhpSetsMethod(__FUNCTION__);
-    }
-
-    #[Deprecated(message: 'Use "withPhpLevel()" instead, it raises PHP level one rule at a time.')]
-    public function withPhp56Sets(): self
-    {
-        return $this->reportDeprecatedPhpSetsMethod(__FUNCTION__);
-    }
-
-    #[Deprecated(message: 'Use "withPhpLevel()" instead, it raises PHP level one rule at a time.')]
-    public function withPhp70Sets(): self
-    {
-        return $this->reportDeprecatedPhpSetsMethod(__FUNCTION__);
-    }
-
-    #[Deprecated(message: 'Use "withPhpLevel()" instead, it raises PHP level one rule at a time.')]
-    public function withPhp71Sets(): self
-    {
-        return $this->reportDeprecatedPhpSetsMethod(__FUNCTION__);
-    }
-
-    #[Deprecated(message: 'Use "withPhpLevel()" instead, it raises PHP level one rule at a time.')]
-    public function withPhp72Sets(): self
-    {
-        return $this->reportDeprecatedPhpSetsMethod(__FUNCTION__);
-    }
-
-    #[Deprecated(message: 'Use "withPhpLevel()" instead, it raises PHP level one rule at a time.')]
-    public function withPhp73Sets(): self
-    {
-        return $this->reportDeprecatedPhpSetsMethod(__FUNCTION__);
-    }
-
-    #[Deprecated(message: 'Use "withPhpLevel()" instead, it raises PHP level one rule at a time.')]
-    public function withPhp74Sets(): self
-    {
-        return $this->reportDeprecatedPhpSetsMethod(__FUNCTION__);
-    }
-
     // there is no withPhp80Sets() and above,
     // as we already use PHP 8.0 and should go with withPhpSets() instead
 
@@ -1165,13 +1111,6 @@ private function addPhpLevelSets(int $phpVersion): self
         return $this;
     }
 
-    private function reportDeprecatedPhpSetsMethod(string $methodName): self
-    {
-        SimpleParameterProvider::addParameter(Option::DEPRECATED_PHP_SETS_METHODS, $methodName);
-
-        return $this;
-    }
-
     /**
      * @param array<class-string<RectorInterface>> $availableRules
      */

src/Console/Command/ProcessCommand.php

@@ -195,7 +195,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         // 4. Deprecations reporter
         $this->deprecatedRulesReporter->reportDeprecatedRules();
         $this->deprecatedRulesReporter->reportDeprecatedSkippedRules();
-        $this->deprecatedRulesReporter->reportDeprecatedPhpSetsMethods();
         $this->deprecatedRulesReporter->reportDeprecatedAttributesSetsArgs();
         $this->deprecatedRulesReporter->reportDeprecatedComposerBasedArgs();
 

src/Console/Command/ValidateConfigCommand.php

@@ -59,7 +59,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         $issueCount += $this->deprecatedRulesReporter->reportDeprecatedRules();
         $issueCount += $this->deprecatedRulesReporter->reportDeprecatedSkippedRules();
-        $issueCount += $this->deprecatedRulesReporter->reportDeprecatedPhpSetsMethods();
         $issueCount += $this->deprecatedRulesReporter->reportDeprecatedAttributesSetsArgs();
         $issueCount += $this->deprecatedRulesReporter->reportDeprecatedComposerBasedArgs();
 

src/Reporting/DeprecatedRulesReporter.php

@@ -57,25 +57,6 @@ public function reportDeprecatedSkippedRules(): int
         return $reportedCount;
     }
 
-    public function reportDeprecatedPhpSetsMethods(): int
-    {
-        /** @var string[] $deprecatedPhpSetsMethods */
-        $deprecatedPhpSetsMethods = SimpleParameterProvider::provideArrayParameter(
-            Option::DEPRECATED_PHP_SETS_METHODS
-        );
-
-        $reportedCount = 0;
-        foreach (array_unique($deprecatedPhpSetsMethods) as $deprecatedPhpSetsMethod) {
-            $this->symfonyStyle->warning(sprintf(
-                'The "->%s()" method is deprecated and no longer applied. Use "->withPhpLevel()" instead, to raise PHP level one rule at a time.',
-                $deprecatedPhpSetsMethod
-            ));
-            ++$reportedCount;
-        }
-
-        return $reportedCount;
-    }
-
     public function reportDeprecatedAttributesSetsArgs(): int
     {
         /** @var string[] $deprecatedAttributesSetsArgs */

tests/Console/Command/ValidateConfigCommandTest.php

@@ -36,7 +36,6 @@ protected function setUp(): void
             Option::SKIPPED_NON_RECTOR_CLASSES,
             Option::SKIPPED_RECTOR_RULES,
             Option::SKIPPED_START_WITH_SHORT_OPEN_TAG_FILES,
-            Option::DEPRECATED_PHP_SETS_METHODS,
             Option::DEPRECATED_ATTRIBUTES_SETS_ARGS,
             Option::DEPRECATED_COMPOSER_BASED_ARGS,
             Option::ROOT_STANDALONE_REGISTERED_RULES,