[ci-review] Rector Rectify

Author: actions-user

utils/phpstan/src/Rule/CheaperGuardFirstRule.php

@@ -4,6 +4,12 @@
 
 namespace Rector\Utils\PHPStan\Rule;
 
+use PhpParser\Node\Stmt\Else_;
+use PhpParser\Node\Expr\MethodCall;
+use PhpParser\Node\Expr\NullsafeMethodCall;
+use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Name;
 use PhpParser\Node;
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\CallLike;
@@ -33,17 +39,14 @@
  */
 final class CheaperGuardFirstRule implements Rule
 {
-    /**
-     * @var string
-     */
-    private const ERROR_MESSAGE = 'Cheap guard on line %d can run before the expensive call on line %d; move the early return up to bail before the costly analysis.';
+    private const string ERROR_MESSAGE = 'Cheap guard on line %d can run before the expensive call on line %d; move the early return up to bail before the costly analysis.';
 
     /**
      * Calls that trigger heavy analysis (type resolution, docblock parsing, file re-parsing).
      *
      * @var string[]
      */
-    private const EXPENSIVE_CALLS = [
+    private const array EXPENSIVE_CALLS = [
         'getType',
         'getNativeType',
         'isObjectType',
@@ -57,18 +60,15 @@ final class CheaperGuardFirstRule implements Rule
      *
      * @var string[]
      */
-    private const CHEAP_CALLS = [
+    private const array CHEAP_CALLS = [
         'isName',
         'isNames',
         'isFirstClassCallable',
         'in_array',
         'count',
     ];
 
-    /**
-     * @var string
-     */
-    private const ABSTRACT_RECTOR_CLASS = 'Rector\Rector\AbstractRector';
+    private const string ABSTRACT_RECTOR_CLASS = 'Rector\Rector\AbstractRector';
 
     public function getNodeType(): string
     {
@@ -101,8 +101,9 @@ public function processNode(Node $node, Scope $scope): array
         }
 
         $assignedVariableNames = $this->resolveAssignedVariableNames($stmts[$anchorIndex]);
+        $counter = count($stmts);
 
-        for ($index = $anchorIndex + 1; $index < count($stmts); ++$index) {
+        for ($index = $anchorIndex + 1; $index < $counter; ++$index) {
             $stmt = $stmts[$index];
 
             if ($this->isPureBailGuard($stmt)) {
@@ -158,7 +159,7 @@ private function isPureBailGuard(Stmt $stmt): bool
             return false;
         }
 
-        if ($stmt->elseifs !== [] || $stmt->else !== null) {
+        if ($stmt->elseifs !== [] || $stmt->else instanceof Else_) {
             return false;
         }
 
@@ -238,12 +239,12 @@ private function containsCall(Node $node, array $callNames): bool
 
     private function resolveCallName(CallLike $callLike): ?string
     {
-        if ($callLike instanceof Node\Expr\MethodCall || $callLike instanceof Node\Expr\NullsafeMethodCall || $callLike instanceof Node\Expr\StaticCall) {
+        if ($callLike instanceof MethodCall || $callLike instanceof NullsafeMethodCall || $callLike instanceof StaticCall) {
             return $callLike->name instanceof Identifier ? $callLike->name->toString() : null;
         }
 
-        if ($callLike instanceof Node\Expr\FuncCall) {
-            return $callLike->name instanceof Node\Name ? $callLike->name->toString() : null;
+        if ($callLike instanceof FuncCall) {
+            return $callLike->name instanceof Name ? $callLike->name->toString() : null;
         }
 
         return null;