Drop scope on class extends/implements names, rename extends at Class_ level (#8788)

Author: TomasVotruba

rules/Renaming/NodeManipulator/ClassRenamer.php

@@ -20,6 +20,7 @@
 use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocClassRenamer;
 use Rector\BetterPhpDocParser\ValueObject\NodeTypes;
 use Rector\Comments\NodeDocBlock\DocBlockUpdater;
+use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\NodeTypeResolver\PhpDoc\NodeAnalyzer\DocBlockClassRenamer;
 use Rector\NodeTypeResolver\ValueObject\OldToNewType;
@@ -44,7 +45,8 @@ public function __construct(
         private readonly DocBlockClassRenamer $docBlockClassRenamer,
         private readonly ReflectionProvider $reflectionProvider,
         private readonly DocBlockUpdater $docBlockUpdater,
-        private readonly RenamedNameCollector $renamedNameCollector
+        private readonly RenamedNameCollector $renamedNameCollector,
+        private readonly NodeNameResolver $nodeNameResolver
     ) {
     }
 
@@ -56,14 +58,14 @@ public function renameNode(Node $node, array $oldToNewClasses, ?Scope $scope): ?
     {
         // execute FullyQualified before Name on purpose so next Name check is pure Name node
         if ($node instanceof FullyQualified) {
-            return $this->refactorName($node, $oldToNewClasses, $scope);
+            return $this->refactorName($node, $oldToNewClasses);
         }
 
         // Name as parent of FullyQualified executed for fallback annotation to attribute rename to Name
         if ($node instanceof Name) {
             $phpAttributeName = $node->getAttribute(AttributeKey::PHP_ATTRIBUTE_NAME);
             if (is_string($phpAttributeName)) {
-                return $this->refactorName(new FullyQualified($phpAttributeName), $oldToNewClasses, $scope);
+                return $this->refactorName(new FullyQualified($phpAttributeName), $oldToNewClasses);
             }
 
             return null;
@@ -141,21 +143,25 @@ private function shouldSkip(string $newName, FullyQualified $fullyQualified): bo
      */
     private function refactorName(
         FullyQualified $fullyQualified,
-        array $oldToNewClasses,
-        ?Scope $scope
+        array $oldToNewClasses
     ): ?FullyQualified {
         if ($fullyQualified->getAttribute(AttributeKey::IS_FUNCCALL_NAME) === true) {
             return null;
         }
 
+        // class extends is handled on Class_ node level, to resolve self-extends without scope
+        if ($fullyQualified->getAttribute(AttributeKey::IS_CLASS_EXTENDS) === true) {
+            return null;
+        }
+
         $stringName = $fullyQualified->toString();
         $newName = $oldToNewClasses[$stringName] ?? null;
 
         if ($newName === null) {
             return null;
         }
 
-        if (! $this->isClassToInterfaceValidChange($fullyQualified, $newName, $scope)) {
+        if (! $this->isClassToInterfaceValidChange($fullyQualified, $newName)) {
             return null;
         }
 
@@ -178,6 +184,22 @@ private function refactorClassLike(ClassLike $classLike, array $oldToNewClasses,
         }
 
         $hasChanged = false;
+
+        if ($classLike->extends instanceof FullyQualified) {
+            $extendsName = $classLike->extends->toString();
+            $newName = $oldToNewClasses[$extendsName] ?? null;
+
+            // skip when the class would extend itself after rename; this might happen when you run a rename class on new child class that extends the deprecated one
+            if ($newName !== null
+                && $newName !== $this->nodeNameResolver->getName($classLike)
+                && $this->isClassToInterfaceValidChange($classLike->extends, $newName)
+            ) {
+                $this->renamedNameCollector->add($extendsName);
+                $classLike->extends = new FullyQualified($newName);
+                $hasChanged = true;
+            }
+        }
+
         $classLike->implements = array_unique($classLike->implements);
         foreach ($classLike->implements as $key => $implementName) {
             $namespaceName = $scope instanceof Scope ? $scope->getNamespace() : null;
@@ -213,8 +235,7 @@ private function refactorClassLike(ClassLike $classLike, array $oldToNewClasses,
      */
     private function isClassToInterfaceValidChange(
         FullyQualified $fullyQualified,
-        string $newClassName,
-        ?Scope $scope
+        string $newClassName
     ): bool {
         if (! $this->reflectionProvider->hasClass($newClassName)) {
             return true;
@@ -223,14 +244,6 @@ private function isClassToInterfaceValidChange(
         $classReflection = $this->reflectionProvider->getClass($newClassName);
         // ensure new is not with interface
         if ($fullyQualified->getAttribute(AttributeKey::IS_NEW_INSTANCE_NAME) !== true) {
-            if ($fullyQualified->getAttribute(AttributeKey::IS_CLASS_EXTENDS) === true && $scope instanceof Scope) {
-                $currentClassReflection = $scope->getClassReflection();
-
-                if ($currentClassReflection instanceof ClassReflection && $currentClassReflection->getName() === $newClassName) {
-                    return false;
-                }
-            }
-
             return $this->isValidClassNameChange($fullyQualified, $classReflection);
         }
 

src/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php

@@ -52,7 +52,6 @@
 use PhpParser\Node\Identifier;
 use PhpParser\Node\IntersectionType;
 use PhpParser\Node\Name;
-use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\NullableType;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Catch_;
@@ -166,22 +165,15 @@ private function fillScope(array $stmts, string $filePath, MutatingScope $scope)
                 $mutatingScope = $mutatingScope->toWalkScope();
             }
 
+            // why not simply this everywhere? what would we lose?
+            // $node->setAttribute(AttributeKey::SCOPE, $mutatingScope);
+
             // the class reflection is resolved AFTER entering to class node
             // so we need to get it from the first after this one
             if ($node instanceof Class_ || $node instanceof Interface_ || $node instanceof Enum_) {
                 $mutatingScope = $this->resolveClassOrInterfaceScope($node, $mutatingScope);
                 $node->setAttribute(AttributeKey::SCOPE, $mutatingScope);
 
-                if ($node instanceof Class_) {
-                    if ($node->extends instanceof FullyQualified) {
-                        $node->extends->setAttribute(AttributeKey::SCOPE, $mutatingScope);
-                    }
-
-                    foreach ($node->implements as $implement) {
-                        $implement->setAttribute(AttributeKey::SCOPE, $mutatingScope);
-                    }
-                }
-
                 return;
             }